fix(build): handle relative paths with missing authority

rodneyrehm · rodneyrehm · commit 4ced30a1c5ad · 2019-10-20T16:35:25.000+02:00
closes #387
diff --git a/src/URI.js b/src/URI.js
@@ -669,19 +669,21 @@
 
   URI.build = function(parts) {
     var t = '';
+    var requireAbsolutePath = false
 
     if (parts.protocol) {
       t += parts.protocol + ':';
     }
 
     if (!parts.urn && (t || parts.hostname)) {
       t += '//';
+      requireAbsolutePath = true
     }
 
     t += (URI.buildAuthority(parts) || '');
 
     if (typeof parts.path === 'string') {
-      if (parts.path.charAt(0) !== '/' && typeof parts.hostname === 'string') {
+      if (parts.path.charAt(0) !== '/' && requireAbsolutePath) {
         t += '/';
       }
 
diff --git a/test/test.js b/test/test.js
@@ -234,6 +234,16 @@
     })(t);
   }
 
+  module('serializing');
+  test('scheme and relative path', function() {
+    var u = new URI('')
+      .protocol('food')
+      .path('test/file.csv')
+      .toString()
+
+    equal(u.toString(), 'food:///test/file.csv', 'relative-path with scheme but no authority');
+  });
+
   module('mutating basics');
   test('protocol', function() {
     var u = new URI('http://example.org/foo.html');
diff --git a/test/urls.js b/test/urls.js
@@ -629,6 +629,54 @@ var urls = [{
       idn: false,
       punycode: false
     }
+  }, {
+    name: 'missing authority',
+    url: 'food:///test/file.csv',
+    parts: {
+      protocol: 'food',
+      username: null,
+      password: null,
+      hostname: null,
+      port: null,
+      path: '/test/file.csv',
+      query: null,
+      fragment: null
+    },
+    accessors: {
+      protocol: 'food',
+      username: '',
+      password: '',
+      port: '',
+      path: '/test/file.csv',
+      query: '',
+      fragment: '',
+      resource: '/test/file.csv',
+      authority: '',
+      origin: '',
+      userinfo: '',
+      subdomain: '',
+      domain: '',
+      tld: '',
+      directory: '/test',
+      filename: 'file.csv',
+      suffix: 'csv',
+      hash: '',
+      search: '',
+      host: '',
+      hostname: ''
+    },
+    is: {
+      urn: false,
+      url: true,
+      relative: true,
+      name: false,
+      sld: false,
+      ip: false,
+      ip4: false,
+      ip6: false,
+      idn: false,
+      punycode: false
+    }
   }, {
     name: 'IPv4',
     url: 'http://user:pass@123.123.123.123:123/some/directory/file.html?query=string#fragment',

Original file line number	Diff line number	Diff line change
`@@ -669,19 +669,21 @@`
`669`	`669`
`670`	`670`	`URI.build = function(parts) {`
`671`	`671`	`var t = '';`
	`672`	`+ var requireAbsolutePath = false`
`672`	`673`
`673`	`674`	`if (parts.protocol) {`
`674`	`675`	`t += parts.protocol + ':';`
`675`	`676`	`}`
`676`	`677`
`677`	`678`	`if (!parts.urn && (t \|\| parts.hostname)) {`
`678`	`679`	`t += '//';`
	`680`	`+ requireAbsolutePath = true`
`679`	`681`	`}`
`680`	`682`
`681`	`683`	`t += (URI.buildAuthority(parts) \|\| '');`
`682`	`684`
`683`	`685`	`if (typeof parts.path === 'string') {`
`684`		`- if (parts.path.charAt(0) !== '/' && typeof parts.hostname === 'string') {`
	`686`	`+ if (parts.path.charAt(0) !== '/' && requireAbsolutePath) {`
`685`	`687`	`t += '/';`
`686`	`688`	`}`
`687`	`689`