Skip to content

Commit 2665176

Browse files
committed
Minify CodeMirror and Acorn dependencies to speed up page loading
1 parent 390f7e7 commit 2665176

File tree

5 files changed

+16
-26
lines changed

5 files changed

+16
-26
lines changed

.gitignore

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,7 @@
88
/book.pdf
99
/html/[012]*.html
1010
/html/js/chapter_info.js
11+
/html/js/acorn_codemirror.js
1112
/code/chapter/*
1213
/code/file_server.js
1314
/code/skillsharing.zip

Makefile

Lines changed: 11 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ CHAPTERS := 00_intro 01_values 02_program_structure 03_functions 04_data 05_high
44

55
SVGS := $(wildcard img/*.svg)
66

7-
html: $(foreach CHAP,$(CHAPTERS),html/$(CHAP).html) html/js/chapter_info.js \
7+
html: $(foreach CHAP,$(CHAPTERS),html/$(CHAP).html) html/js/chapter_info.js html/js/acorn_codemirror.js \
88
code/skillsharing.zip code/solutions/20_4_a_public_space_on_the_web.zip \
99
$(patsubst img/%.svg,img/generated/%.png,$(SVGS))
1010

@@ -15,6 +15,16 @@ html/%.html: %.txt asciidoc_html.conf
1515
html/js/chapter_info.js: $(foreach CHAP,$(CHAPTERS),$(CHAP).txt) code/solutions/* bin/chapter_info.js
1616
node bin/chapter_info.js > html/js/chapter_info.js
1717

18+
html/js/acorn_codemirror.js: node_modules/codemirror/lib/codemirror.js \
19+
node_modules/codemirror/mode/javascript/javascript.js \
20+
node_modules/codemirror/mode/css/css.js \
21+
node_modules/codemirror/mode/xml/xml.js \
22+
node_modules/codemirror/mode/htmlmixed/htmlmixed.js \
23+
node_modules/codemirror/addon/edit/matchbrackets.js \
24+
node_modules/acorn/acorn.js \
25+
node_modules/acorn/util/walk.js
26+
node_modules/.bin/uglifyjs $? -m -o $@
27+
1828
img/generated/%.png: img/%.svg
1929
inkscape --export-png=$@ $<
2030

asciidoc_html.conf

Lines changed: 1 addition & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -72,14 +72,7 @@ template::[source-filter-style]
7272
<meta charset="utf-8">
7373
<title>{doctitle} :: Eloquent JavaScript</title>
7474
<link rel=stylesheet href="js/node_modules/codemirror/lib/codemirror.css">
75-
<script src="js/node_modules/codemirror/lib/codemirror.js"></script>
76-
<script src="js/node_modules/codemirror/mode/javascript/javascript.js"></script>
77-
<script src="js/node_modules/codemirror/mode/css/css.js"></script>
78-
<script src="js/node_modules/codemirror/mode/xml/xml.js"></script>
79-
<script src="js/node_modules/codemirror/mode/htmlmixed/htmlmixed.js"></script>
80-
<script src="js/node_modules/codemirror/addon/edit/matchbrackets.js"></script>
81-
<script src="js/node_modules/acorn/acorn.js"></script>
82-
<script src="js/node_modules/acorn/util/walk.js"></script>
75+
<script src="js/acorn_codemirror.js"></script>
8376
<link rel=stylesheet href="css/ejs.css">
8477
<script src="js/sandbox.js"></script>
8578
<script src="js/ejs.js"></script>

code/index.html

Lines changed: 1 addition & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -5,23 +5,8 @@
55
<title>Eloquent JavaScript :: Code Sandbox</title>
66

77
<link rel=stylesheet href="js/node_modules/codemirror/lib/codemirror.css">
8-
<script src="js/node_modules/codemirror/lib/codemirror.js"></script>
9-
<script src="js/node_modules/codemirror/mode/javascript/javascript.js"></script>
10-
<script src="js/node_modules/codemirror/mode/css/css.js"></script>
11-
<script src="js/node_modules/codemirror/mode/xml/xml.js"></script>
12-
<script src="js/node_modules/codemirror/mode/htmlmixed/htmlmixed.js"></script>
13-
<script src="js/node_modules/codemirror/addon/edit/matchbrackets.js"></script>
14-
<script src="js/node_modules/acorn/acorn.js"></script>
15-
<script src="js/node_modules/acorn/util/walk.js"></script>
8+
<script src="js/acorn_codemirror.js"></script>
169
<link rel=stylesheet href="js/node_modules/codemirror/lib/codemirror.css">
17-
<script src="js/node_modules/codemirror/lib/codemirror.js"></script>
18-
<script src="js/node_modules/codemirror/mode/javascript/javascript.js"></script>
19-
<script src="js/node_modules/codemirror/mode/css/css.js"></script>
20-
<script src="js/node_modules/codemirror/mode/xml/xml.js"></script>
21-
<script src="js/node_modules/codemirror/mode/htmlmixed/htmlmixed.js"></script>
22-
<script src="js/node_modules/codemirror/addon/edit/matchbrackets.js"></script>
23-
<script src="js/node_modules/acorn/acorn.js"></script>
24-
<script src="js/node_modules/acorn/util/walk.js"></script>
2510
<link rel=stylesheet href="css/ejs.css">
2611
<script src="js/sandbox.js"></script>
2712
<script src="js/chapter_info.js"></script>

package.json

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,8 @@
1010
},
1111
"dependencies": {
1212
"acorn": "0.3",
13-
"codemirror": "4"
13+
"codemirror": "4",
14+
"uglify-js": "2"
1415
},
1516
"devDependencies": {
1617
"contextify": "kkoopa/contextify",

0 commit comments

Comments
 (0)