Skip to content

Commit 085903a

Browse files
committed
Rename DefaultTableDefinition to TableDefinition
1 parent 36d9dc3 commit 085903a

File tree

15 files changed

+105
-101
lines changed

15 files changed

+105
-101
lines changed

README.md

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -127,9 +127,11 @@ must [supply credentials](#authentication) and a project ID if running this snip
127127
```java
128128
import com.google.gcloud.bigquery.BigQuery;
129129
import com.google.gcloud.bigquery.BigQueryOptions;
130+
import com.google.gcloud.bigquery.TableDefinition;
130131
import com.google.gcloud.bigquery.Field;
131132
import com.google.gcloud.bigquery.JobStatus;
132133
import com.google.gcloud.bigquery.JobInfo;
134+
import com.google.gcloud.bigquery.LoadJobConfiguration;
133135
import com.google.gcloud.bigquery.Schema;
134136
import com.google.gcloud.bigquery.TableId;
135137
import com.google.gcloud.bigquery.TableInfo;
@@ -141,7 +143,7 @@ if (info == null) {
141143
System.out.println("Creating table " + tableId);
142144
Field integerField = Field.of("fieldName", Field.Type.integer());
143145
Schema schema = Schema.of(integerField);
144-
bigquery.create(TableInfo.of(tableId, DefaultTableDefinition.of(schema)));
146+
bigquery.create(TableInfo.of(tableId, TableDefinition.of(schema)));
145147
} else {
146148
System.out.println("Loading data into table " + tableId);
147149
LoadJobConfiguration configuration = LoadJobConfiguration.of(tableId, "gs://bucket/path");

gcloud-java-bigquery/README.md

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -111,7 +111,7 @@ are created from a BigQuery SQL query. In this code snippet we show how to creat
111111
with only one string field. Add the following imports at the top of your file:
112112

113113
```java
114-
import com.google.gcloud.bigquery.DefaultTableDefinition;
114+
import com.google.gcloud.bigquery.TableDefinition;
115115
import com.google.gcloud.bigquery.Field;
116116
import com.google.gcloud.bigquery.Schema;
117117
import com.google.gcloud.bigquery.TableId;
@@ -126,7 +126,7 @@ Field stringField = Field.of("StringField", Field.Type.string());
126126
// Table schema definition
127127
Schema schema = Schema.of(stringField);
128128
// Create a table
129-
DefaultTableDefinition tableDefinition = DefaultTableDefinition.of(schema);
129+
TableDefinition tableDefinition = TableDefinition.of(schema);
130130
TableInfo createdTableInfo = bigquery.create(TableInfo.of(tableId, tableDefinition));
131131
```
132132

@@ -208,7 +208,7 @@ display on your webpage.
208208
import com.google.gcloud.bigquery.BigQuery;
209209
import com.google.gcloud.bigquery.BigQueryOptions;
210210
import com.google.gcloud.bigquery.DatasetInfo;
211-
import com.google.gcloud.bigquery.DefaultTableDefinition;
211+
import com.google.gcloud.bigquery.TableDefinition;
212212
import com.google.gcloud.bigquery.Field;
213213
import com.google.gcloud.bigquery.FieldValue;
214214
import com.google.gcloud.bigquery.InsertAllRequest;
@@ -241,7 +241,7 @@ public class GcloudBigQueryExample {
241241
// Table schema definition
242242
Schema schema = Schema.of(stringField);
243243
// Create a table
244-
DefaultTableDefinition tableDefinition = DefaultTableDefinition.of(schema);
244+
TableDefinition tableDefinition = TableDefinition.of(schema);
245245
TableInfo createdTableInfo = bigquery.create(TableInfo.of(tableId, tableDefinition));
246246

247247
// Define rows to insert

gcloud-java-bigquery/src/main/java/com/google/gcloud/bigquery/BaseTableDefinition.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@ public abstract class BaseTableDefinition implements Serializable {
3737
public enum Type {
3838
/**
3939
* A normal BigQuery table. Instances of {@code BaseTableDefinition} for this type are
40-
* implemented by {@link DefaultTableDefinition}.
40+
* implemented by {@link TableDefinition}.
4141
*/
4242
TABLE,
4343

@@ -169,7 +169,7 @@ Table toPb() {
169169
static <T extends BaseTableDefinition> T fromPb(Table tablePb) {
170170
switch (Type.valueOf(tablePb.getType())) {
171171
case TABLE:
172-
return (T) DefaultTableDefinition.fromPb(tablePb);
172+
return (T) TableDefinition.fromPb(tablePb);
173173
case VIEW:
174174
return (T) ViewDefinition.fromPb(tablePb);
175175
case EXTERNAL:

gcloud-java-bigquery/src/main/java/com/google/gcloud/bigquery/DefaultTableDefinition.java renamed to gcloud-java-bigquery/src/main/java/com/google/gcloud/bigquery/TableDefinition.java

Lines changed: 11 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@
3333
*
3434
* @see <a href="https://cloud.google.com/bigquery/docs/tables">Managing Tables</a>
3535
*/
36-
public class DefaultTableDefinition extends BaseTableDefinition {
36+
public class TableDefinition extends BaseTableDefinition {
3737

3838
private static final long serialVersionUID = 2113445776046717900L;
3939

@@ -116,7 +116,7 @@ static StreamingBuffer fromPb(Streamingbuffer streamingBufferPb) {
116116
}
117117

118118
public static final class Builder
119-
extends BaseTableDefinition.Builder<DefaultTableDefinition, Builder> {
119+
extends BaseTableDefinition.Builder<TableDefinition, Builder> {
120120

121121
private Long numBytes;
122122
private Long numRows;
@@ -127,7 +127,7 @@ private Builder() {
127127
super(Type.TABLE);
128128
}
129129

130-
private Builder(DefaultTableDefinition tableDefinition) {
130+
private Builder(TableDefinition tableDefinition) {
131131
super(tableDefinition);
132132
this.numBytes = tableDefinition.numBytes;
133133
this.numRows = tableDefinition.numRows;
@@ -168,15 +168,15 @@ Builder streamingBuffer(StreamingBuffer streamingBuffer) {
168168
}
169169

170170
/**
171-
* Creates a {@code DefaultTableDefinition} object.
171+
* Creates a {@code TableDefinition} object.
172172
*/
173173
@Override
174-
public DefaultTableDefinition build() {
175-
return new DefaultTableDefinition(this);
174+
public TableDefinition build() {
175+
return new TableDefinition(this);
176176
}
177177
}
178178

179-
private DefaultTableDefinition(Builder builder) {
179+
private TableDefinition(Builder builder) {
180180
super(builder);
181181
this.numBytes = builder.numBytes;
182182
this.numRows = builder.numRows;
@@ -229,12 +229,12 @@ public static Builder builder() {
229229
*
230230
* @param schema the schema of the table
231231
*/
232-
public static DefaultTableDefinition of(Schema schema) {
232+
public static TableDefinition of(Schema schema) {
233233
return builder().schema(schema).build();
234234
}
235235

236236
/**
237-
* Returns a builder for the {@code DefaultTableDefinition} object.
237+
* Returns a builder for the {@code TableDefinition} object.
238238
*/
239239
@Override
240240
public Builder toBuilder() {
@@ -252,7 +252,7 @@ ToStringHelper toStringHelper() {
252252

253253
@Override
254254
public boolean equals(Object obj) {
255-
return obj instanceof DefaultTableDefinition && baseEquals((DefaultTableDefinition) obj);
255+
return obj instanceof TableDefinition && baseEquals((TableDefinition) obj);
256256
}
257257

258258
@Override
@@ -275,7 +275,7 @@ Table toPb() {
275275
}
276276

277277
@SuppressWarnings("unchecked")
278-
static DefaultTableDefinition fromPb(Table tablePb) {
278+
static TableDefinition fromPb(Table tablePb) {
279279
return new Builder(tablePb).build();
280280
}
281281
}

gcloud-java-bigquery/src/main/java/com/google/gcloud/bigquery/TableInfo.java

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -30,9 +30,9 @@
3030
import java.util.Objects;
3131

3232
/**
33-
* Google BigQuery table information. Use {@link DefaultTableDefinition} to create simple BigQuery
34-
* table. Use {@link ViewDefinition} to create a BigQuery view. Use {@link ExternalTableDefinition}
35-
* to create a BigQuery a table backed by external data.
33+
* Google BigQuery table information. Use {@link TableDefinition} to create simple BigQuery table.
34+
* Use {@link ViewDefinition} to create a BigQuery view. Use {@link ExternalTableDefinition} to
35+
* create a BigQuery a table backed by external data.
3636
*
3737
* @see <a href="https://cloud.google.com/bigquery/docs/tables">Managing Tables</a>
3838
*/
@@ -171,7 +171,9 @@ public Builder tableId(TableId tableId) {
171171
}
172172

173173
/**
174-
* Sets the table definition.
174+
* Sets the table definition. Use {@link TableDefinition} to create simple BigQuery table. Use
175+
* {@link ViewDefinition} to create a BigQuery view. Use {@link ExternalTableDefinition} to
176+
* create a BigQuery a table backed by external data.
175177
*/
176178
public Builder definition(BaseTableDefinition definition) {
177179
this.definition = checkNotNull(definition);

gcloud-java-bigquery/src/main/java/com/google/gcloud/bigquery/package-info.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@
2626
* System.out.println("Creating table " + tableId);
2727
* Field integerField = Field.of("fieldName", Field.Type.integer());
2828
* Schema schema = Schema.of(integerField);
29-
* bigquery.create(TableInfo.of(tableId, DefaultTableDefinition.of(schema)));
29+
* bigquery.create(TableInfo.of(tableId, TableDefinition.of(schema)));
3030
* } else {
3131
* System.out.println("Loading data into table " + tableId);
3232
* LoadJobConfiguration configuration = LoadJobConfiguration.of(tableId, "gs://bucket/path");

gcloud-java-bigquery/src/test/java/com/google/gcloud/bigquery/BigQueryImplTest.java

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -104,11 +104,11 @@ public class BigQueryImplTest {
104104
.description("FieldDescription3")
105105
.build();
106106
private static final Schema TABLE_SCHEMA = Schema.of(FIELD_SCHEMA1, FIELD_SCHEMA2, FIELD_SCHEMA3);
107-
private static final DefaultTableDefinition TABLE_TYPE = DefaultTableDefinition.of(TABLE_SCHEMA);
108-
private static final TableInfo TABLE_INFO = TableInfo.of(TABLE_ID, TABLE_TYPE);
109-
private static final TableInfo OTHER_TABLE_INFO = TableInfo.of(OTHER_TABLE_ID, TABLE_TYPE);
107+
private static final TableDefinition TABLE_DEFINITION = TableDefinition.of(TABLE_SCHEMA);
108+
private static final TableInfo TABLE_INFO = TableInfo.of(TABLE_ID, TABLE_DEFINITION);
109+
private static final TableInfo OTHER_TABLE_INFO = TableInfo.of(OTHER_TABLE_ID, TABLE_DEFINITION);
110110
private static final TableInfo TABLE_INFO_WITH_PROJECT =
111-
TableInfo.of(TABLE_ID_WITH_PROJECT, TABLE_TYPE);
111+
TableInfo.of(TABLE_ID_WITH_PROJECT, TABLE_DEFINITION);
112112
private static final LoadJobConfiguration LOAD_JOB_CONFIGURATION =
113113
LoadJobConfiguration.of(TABLE_ID, "URI");
114114
private static final LoadJobConfiguration LOAD_JOB_CONFIGURATION_WITH_PROJECT =

gcloud-java-bigquery/src/test/java/com/google/gcloud/bigquery/DatasetTest.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -44,8 +44,8 @@ public class DatasetTest {
4444
private static final DatasetId DATASET_ID = DatasetId.of("dataset");
4545
private static final DatasetInfo DATASET_INFO = DatasetInfo.builder(DATASET_ID).build();
4646
private static final Field FIELD = Field.of("FieldName", Field.Type.integer());
47-
private static final DefaultTableDefinition TABLE_DEFINITION =
48-
DefaultTableDefinition.of(Schema.of(FIELD));
47+
private static final TableDefinition TABLE_DEFINITION =
48+
TableDefinition.of(Schema.of(FIELD));
4949
private static final ViewDefinition VIEW_DEFINITION = ViewDefinition.of("QUERY");
5050
private static final ExternalTableDefinition EXTERNAL_TABLE_DEFINITION =
5151
ExternalTableDefinition.of(ImmutableList.of("URI"), Schema.of(), FormatOptions.csv());

gcloud-java-bigquery/src/test/java/com/google/gcloud/bigquery/ITBigQueryTest.java

Lines changed: 21 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -257,44 +257,44 @@ public void testGetNonExistingTable() {
257257
public void testCreateAndGetTable() {
258258
String tableName = "test_create_and_get_table";
259259
TableId tableId = TableId.of(DATASET, tableName);
260-
DefaultTableDefinition tableDefinition = DefaultTableDefinition.of(TABLE_SCHEMA);
260+
TableDefinition tableDefinition = TableDefinition.of(TABLE_SCHEMA);
261261
TableInfo createdTableInfo = bigquery.create(TableInfo.of(tableId, tableDefinition));
262262
assertNotNull(createdTableInfo);
263263
assertEquals(DATASET, createdTableInfo.tableId().dataset());
264264
assertEquals(tableName, createdTableInfo.tableId().table());
265265
TableInfo remoteTableInfo = bigquery.getTable(DATASET, tableName);
266266
assertNotNull(remoteTableInfo);
267-
assertTrue(remoteTableInfo.definition() instanceof DefaultTableDefinition);
267+
assertTrue(remoteTableInfo.definition() instanceof TableDefinition);
268268
assertEquals(createdTableInfo.tableId(), remoteTableInfo.tableId());
269269
assertEquals(BaseTableDefinition.Type.TABLE, remoteTableInfo.definition().type());
270270
assertEquals(TABLE_SCHEMA, remoteTableInfo.definition().schema());
271271
assertNotNull(remoteTableInfo.creationTime());
272272
assertNotNull(remoteTableInfo.lastModifiedTime());
273-
assertNotNull(remoteTableInfo.<DefaultTableDefinition>definition().numBytes());
274-
assertNotNull(remoteTableInfo.<DefaultTableDefinition>definition().numRows());
273+
assertNotNull(remoteTableInfo.<TableDefinition>definition().numBytes());
274+
assertNotNull(remoteTableInfo.<TableDefinition>definition().numRows());
275275
assertTrue(bigquery.delete(DATASET, tableName));
276276
}
277277

278278
@Test
279279
public void testCreateAndGetTableWithSelectedField() {
280280
String tableName = "test_create_and_get_selected_fields_table";
281281
TableId tableId = TableId.of(DATASET, tableName);
282-
DefaultTableDefinition tableDefinition = DefaultTableDefinition.of(TABLE_SCHEMA);
282+
TableDefinition tableDefinition = TableDefinition.of(TABLE_SCHEMA);
283283
TableInfo createdTableInfo = bigquery.create(TableInfo.of(tableId, tableDefinition));
284284
assertNotNull(createdTableInfo);
285285
assertEquals(DATASET, createdTableInfo.tableId().dataset());
286286
assertEquals(tableName, createdTableInfo.tableId().table());
287287
TableInfo remoteTableInfo = bigquery.getTable(DATASET, tableName,
288288
TableOption.fields(TableField.CREATION_TIME));
289289
assertNotNull(remoteTableInfo);
290-
assertTrue(remoteTableInfo.definition() instanceof DefaultTableDefinition);
290+
assertTrue(remoteTableInfo.definition() instanceof TableDefinition);
291291
assertEquals(createdTableInfo.tableId(), remoteTableInfo.tableId());
292292
assertEquals(BaseTableDefinition.Type.TABLE, remoteTableInfo.definition().type());
293293
assertNotNull(remoteTableInfo.creationTime());
294294
assertNull(remoteTableInfo.definition().schema());
295295
assertNull(remoteTableInfo.lastModifiedTime());
296-
assertNull(remoteTableInfo.<DefaultTableDefinition>definition().numBytes());
297-
assertNull(remoteTableInfo.<DefaultTableDefinition>definition().numRows());
296+
assertNull(remoteTableInfo.<TableDefinition>definition().numBytes());
297+
assertNull(remoteTableInfo.<TableDefinition>definition().numRows());
298298
assertTrue(bigquery.delete(DATASET, tableName));
299299
}
300300

@@ -409,7 +409,7 @@ public void testCreateViewTable() throws InterruptedException {
409409
@Test
410410
public void testListTables() {
411411
String tableName = "test_list_tables";
412-
DefaultTableDefinition tableDefinition = DefaultTableDefinition.of(TABLE_SCHEMA);
412+
TableDefinition tableDefinition = TableDefinition.of(TABLE_SCHEMA);
413413
TableInfo tableInfo = TableInfo.of(TableId.of(DATASET, tableName), tableDefinition);
414414
TableInfo createdTableInfo = bigquery.create(tableInfo);
415415
assertNotNull(createdTableInfo);
@@ -428,7 +428,7 @@ public void testListTables() {
428428
@Test
429429
public void testUpdateTable() {
430430
String tableName = "test_update_table";
431-
DefaultTableDefinition tableDefinition = DefaultTableDefinition.of(TABLE_SCHEMA);
431+
TableDefinition tableDefinition = TableDefinition.of(TABLE_SCHEMA);
432432
TableInfo tableInfo = TableInfo.of(TableId.of(DATASET, tableName), tableDefinition);
433433
TableInfo createdTableInfo = bigquery.create(tableInfo);
434434
assertNotNull(createdTableInfo);
@@ -444,27 +444,27 @@ public void testUpdateTable() {
444444
@Test
445445
public void testUpdateTableWithSelectedFields() {
446446
String tableName = "test_update_with_selected_fields_table";
447-
DefaultTableDefinition tableDefinition = DefaultTableDefinition.of(TABLE_SCHEMA);
447+
TableDefinition tableDefinition = TableDefinition.of(TABLE_SCHEMA);
448448
TableInfo tableInfo = TableInfo.of(TableId.of(DATASET, tableName), tableDefinition);
449449
TableInfo createdTableInfo = bigquery.create(tableInfo);
450450
assertNotNull(createdTableInfo);
451451
TableInfo updatedTableInfo = bigquery.update(tableInfo.toBuilder().description("newDescr")
452452
.build(), TableOption.fields(TableField.DESCRIPTION));
453-
assertTrue(updatedTableInfo.definition() instanceof DefaultTableDefinition);
453+
assertTrue(updatedTableInfo.definition() instanceof TableDefinition);
454454
assertEquals(DATASET, updatedTableInfo.tableId().dataset());
455455
assertEquals(tableName, updatedTableInfo.tableId().table());
456456
assertEquals("newDescr", updatedTableInfo.description());
457457
assertNull(updatedTableInfo.definition().schema());
458458
assertNull(updatedTableInfo.lastModifiedTime());
459-
assertNull(updatedTableInfo.<DefaultTableDefinition>definition().numBytes());
460-
assertNull(updatedTableInfo.<DefaultTableDefinition>definition().numRows());
459+
assertNull(updatedTableInfo.<TableDefinition>definition().numBytes());
460+
assertNull(updatedTableInfo.<TableDefinition>definition().numRows());
461461
assertTrue(bigquery.delete(DATASET, tableName));
462462
}
463463

464464
@Test
465465
public void testUpdateNonExistingTable() {
466466
TableInfo tableInfo = TableInfo.of(TableId.of(DATASET, "test_update_non_existing_table"),
467-
DefaultTableDefinition.of(SIMPLE_SCHEMA));
467+
TableDefinition.of(SIMPLE_SCHEMA));
468468
try {
469469
bigquery.update(tableInfo);
470470
fail("BigQueryException was expected");
@@ -484,7 +484,7 @@ public void testDeleteNonExistingTable() {
484484
@Test
485485
public void testInsertAll() {
486486
String tableName = "test_insert_all_table";
487-
DefaultTableDefinition tableDefinition = DefaultTableDefinition.of(TABLE_SCHEMA);
487+
TableDefinition tableDefinition = TableDefinition.of(TABLE_SCHEMA);
488488
TableInfo tableInfo = TableInfo.of(TableId.of(DATASET, tableName), tableDefinition);
489489
assertNotNull(bigquery.create(tableInfo));
490490
InsertAllRequest request = InsertAllRequest.builder(tableInfo.tableId())
@@ -516,7 +516,7 @@ public void testInsertAll() {
516516
@Test
517517
public void testInsertAllWithSuffix() throws InterruptedException {
518518
String tableName = "test_insert_all_with_suffix_table";
519-
DefaultTableDefinition tableDefinition = DefaultTableDefinition.of(TABLE_SCHEMA);
519+
TableDefinition tableDefinition = TableDefinition.of(TABLE_SCHEMA);
520520
TableInfo tableInfo = TableInfo.of(TableId.of(DATASET, tableName), tableDefinition);
521521
assertNotNull(bigquery.create(tableInfo));
522522
InsertAllRequest request = InsertAllRequest.builder(tableInfo.tableId())
@@ -557,7 +557,7 @@ public void testInsertAllWithSuffix() throws InterruptedException {
557557
@Test
558558
public void testInsertAllWithErrors() {
559559
String tableName = "test_insert_all_with_errors_table";
560-
DefaultTableDefinition tableDefinition = DefaultTableDefinition.of(TABLE_SCHEMA);
560+
TableDefinition tableDefinition = TableDefinition.of(TABLE_SCHEMA);
561561
TableInfo tableInfo = TableInfo.of(TableId.of(DATASET, tableName), tableDefinition);
562562
assertNotNull(bigquery.create(tableInfo));
563563
InsertAllRequest request = InsertAllRequest.builder(tableInfo.tableId())
@@ -689,7 +689,7 @@ public void testCreateAndGetJob() throws InterruptedException {
689689
String sourceTableName = "test_create_and_get_job_source_table";
690690
String destinationTableName = "test_create_and_get_job_destination_table";
691691
TableId sourceTable = TableId.of(DATASET, sourceTableName);
692-
DefaultTableDefinition tableDefinition = DefaultTableDefinition.of(TABLE_SCHEMA);
692+
TableDefinition tableDefinition = TableDefinition.of(TABLE_SCHEMA);
693693
TableInfo tableInfo = TableInfo.of(sourceTable, tableDefinition);
694694
TableInfo createdTableInfo = bigquery.create(tableInfo);
695695
assertNotNull(createdTableInfo);
@@ -722,7 +722,7 @@ public void testCreateAndGetJobWithSelectedFields() throws InterruptedException
722722
String sourceTableName = "test_create_and_get_job_with_selected_fields_source_table";
723723
String destinationTableName = "test_create_and_get_job_with_selected_fields_destination_table";
724724
TableId sourceTable = TableId.of(DATASET, sourceTableName);
725-
DefaultTableDefinition tableDefinition = DefaultTableDefinition.of(TABLE_SCHEMA);
725+
TableDefinition tableDefinition = TableDefinition.of(TABLE_SCHEMA);
726726
TableInfo tableInfo = TableInfo.of(sourceTable, tableDefinition);
727727
TableInfo createdTableInfo = bigquery.create(tableInfo);
728728
assertNotNull(createdTableInfo);
@@ -762,7 +762,7 @@ public void testCopyJob() throws InterruptedException {
762762
String sourceTableName = "test_copy_job_source_table";
763763
String destinationTableName = "test_copy_job_destination_table";
764764
TableId sourceTable = TableId.of(DATASET, sourceTableName);
765-
DefaultTableDefinition tableDefinition = DefaultTableDefinition.of(TABLE_SCHEMA);
765+
TableDefinition tableDefinition = TableDefinition.of(TABLE_SCHEMA);
766766
TableInfo tableInfo = TableInfo.of(sourceTable, tableDefinition);
767767
TableInfo createdTableInfo = bigquery.create(tableInfo);
768768
assertNotNull(createdTableInfo);

gcloud-java-bigquery/src/test/java/com/google/gcloud/bigquery/InsertAllRequestTest.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -43,8 +43,8 @@ public class InsertAllRequestTest {
4343
InsertAllRequest.RowToInsert.of("id2", CONTENT2));
4444
private static final TableId TABLE_ID = TableId.of("dataset", "table");
4545
private static final Schema TABLE_SCHEMA = Schema.of();
46-
private static final BaseTableDefinition TABLE_TYPE = DefaultTableDefinition.of(TABLE_SCHEMA);
47-
private static final TableInfo TABLE_INFO = TableInfo.of(TABLE_ID, TABLE_TYPE);
46+
private static final BaseTableDefinition TABLE_DEFINITION = TableDefinition.of(TABLE_SCHEMA);
47+
private static final TableInfo TABLE_INFO = TableInfo.of(TABLE_ID, TABLE_DEFINITION);
4848
private static final boolean SKIP_INVALID_ROWS = true;
4949
private static final boolean IGNORE_UNKNOWN_VALUES = false;
5050
private static final String TEMPLATE_SUFFIX = "templateSuffix";

0 commit comments

Comments
 (0)