Skip to content

Commit 3f5250f

Browse files
committed
Use gh instead of hub. Release from right branch.
1 parent dd67b80 commit 3f5250f

File tree

2 files changed

+4
-7
lines changed

2 files changed

+4
-7
lines changed

README.dev.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ Steps for releasing:
2020
* You do not need to update the version. The release script will do so.
2121
3. Review `CHANGELOG.md` for completeness and correctness. Update its release
2222
date. Commit it.
23-
4. Install or update `hub` as it used by the release script.
23+
4. Install or update [gh](https://github.com/cli/cli) as it used by the release script.
2424
5. Test that `mvn package` can complete successfully. Run `git clean -dxff`
2525
or something similar to clean up afterwards.
2626
5. Run `./dev-bin/release.sh`.

dev-bin/release.sh

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -120,12 +120,9 @@ popd
120120
git push
121121
git push --tags
122122

123-
message="$version
123+
gh release create --target "$(git branch --show-current)" -t "$version" -n "$notes" "$tag" \
124+
"target/geoip2-$version-with-dependencies.zip" \
125+
"target/geoip2-$version-with-dependencies.zip.asc"
124126

125-
$notes"
126-
127-
hub release create -a "target/geoip2-$version-with-dependencies.zip" \
128-
-a "target/geoip2-$version-with-dependencies.zip.asc" \
129-
-m "$message" "$tag"
130127

131128
echo "Remember to do the release on https://oss.sonatype.org/!"

0 commit comments

Comments
 (0)