Install: Only show the language chooser when we have access to the filesystem without asking for credentials.

ocean90 · ocean90 · commit c680af75e807 · 2014-09-02T18:06:36.000Z
fixes #29397. git-svn-id: https://develop.svn.wordpress.org/trunk@29673 602fd350-edb4-49c9-b593-d223f7449a82
diff --git a/src/wp-admin/includes/translation-install.php b/src/wp-admin/includes/translation-install.php
@@ -204,9 +204,37 @@ function wp_download_language_pack( $download ) {
 	$skin = new Automatic_Upgrader_Skin;
 	$upgrader = new Language_Pack_Upgrader( $skin );
 	$translation->type = 'core';
-	/**
-	 * @todo failures (such as non-direct FS)
-	 */
 	$result = $upgrader->upgrade( $translation, array( 'clear_update_cache' => false ) );
+
+	if ( ! $result || is_wp_error( $result ) ) {
+		return false;
+	}
+
 	return $translation->language;
 }
+
+/**
+ * Check if WordPress has access to the filesystem without asking for
+ * credentials.
+ *
+ * @since 4.0.0
+ *
+ * @return bool Returns true on success, false on failure.
+ */
+function wp_can_install_language_pack() {
+	if ( defined( 'DISALLOW_FILE_MODS' ) && DISALLOW_FILE_MODS ) {
+		return false;
+	}
+
+	require_once ABSPATH . 'wp-admin/includes/class-wp-upgrader.php';
+	$skin = new Automatic_Upgrader_Skin;
+	$upgrader = new Language_Pack_Upgrader( $skin );
+
+	$check = $upgrader->fs_connect( array( WP_CONTENT_DIR, WP_LANG_DIR ) );
+
+	if ( ! $check || is_wp_error( $check ) ) {
+		return false;
+	}
+
+	return true;
+}
diff --git a/src/wp-admin/install.php b/src/wp-admin/install.php
@@ -189,7 +189,7 @@ function display_setup_form( $error = null ) {
 switch($step) {
 	case 0: // Step 0
 
-		if ( empty( $langugage ) && ( $languages = wp_get_available_translations() ) ) {
+		if ( wp_can_install_language_pack() && empty( $langugage ) && ( $languages = wp_get_available_translations() ) ) {
 			display_header( 'language-chooser' );
 			echo '<form id="setup" method="post" action="?step=1">';
 			wp_install_language_form( $languages );
diff --git a/src/wp-admin/setup-config.php b/src/wp-admin/setup-config.php
@@ -93,7 +93,7 @@ function setup_config_display_header( $body_classes = array() ) {
 }
 switch($step) {
 	case -1:
-		if ( empty( $language ) && ( $languages = wp_get_available_translations() ) ) {
+		if ( wp_can_install_language_pack() && empty( $language ) && ( $languages = wp_get_available_translations() ) ) {
 			setup_config_display_header( 'language-chooser' );
 			echo '<form id="setup" method="post" action="?step=0">';
 			wp_install_language_form( $languages );

Original file line number	Diff line number	Diff line change
`@@ -93,7 +93,7 @@ function setup_config_display_header( $body_classes = array() ) {`
`93`	`93`	`}`
`94`	`94`	`switch($step) {`
`95`	`95`	`case -1:`
`96`		`- if ( empty( $language ) && ( $languages = wp_get_available_translations() ) ) {`
	`96`	`+ if ( wp_can_install_language_pack() && empty( $language ) && ( $languages = wp_get_available_translations() ) ) {`
`97`	`97`	`setup_config_display_header( 'language-chooser' );`
`98`	`98`	`echo '<form id="setup" method="post" action="?step=0">';`
`99`	`99`	`wp_install_language_form( $languages );`