MSC2346: Bridge information state event#2346
Conversation
|
Note: I also want to modify publicRooms to return information in these state events, since it's useful information to anyone wanting to join a room. |
|
This is probably ready for review now. |
uhoreg
left a comment
There was a problem hiding this comment.
Largely looks good, but have added some bikeshedding and nit picking.
Co-Authored-By: Hubert Chathi <hubert@uhoreg.ca>
|
Added a Slack bridge POC. This means that we now have full implementation for both sides :) |
turt2live
left a comment
There was a problem hiding this comment.
overall this is feeling fine, but the further exposure of the awful third party network API is a bit worrying.
| "avatar_url": "mxc://foo/bar", // Optional | ||
| "external_url": "irc://chat.freenode.net" // Optional | ||
| }, | ||
| "channel": { |
There was a problem hiding this comment.
Nit: Why are we calling this a channel? In Matrix we call these rooms so doesn't it make sense to use the local terminology. Basically "the thing in the source protocol which maps to a room in Matrix". For example if the remote network has groups and Matrix has rooms why are we calling the field channel?
There was a problem hiding this comment.
The same applies for network, as it's used in a fairly similar way as spaces. I think I slightly prefer using "foreign" terms though, since the whole point of this event is bridging to other protocols.
There was a problem hiding this comment.
The problem is that each network will have a different foreign term. So in many cases this term will apply to neither Matrix nor the remote protocol. If we want it to sound "foreign" why not call it foreign_room?
There was a problem hiding this comment.
The naming is mentioned in the alternatives section now
|
This looks to be back with @Half-Shot. |
Signed-off-by: Tulir Asokan <tulir@maunium.net>
Signed-off-by: Tulir Asokan <tulir@maunium.net>
Signed-off-by: Tulir Asokan <tulir@maunium.net>
Signed-off-by: Tulir Asokan <tulir@maunium.net>
Signed-off-by: Tulir Asokan <tulir@maunium.net>
Rendered
Riot POC
Slack Bridge POC
IRC Bridge POC