TST: unpin pytest#31906
Draft
rcomer wants to merge 1 commit into
Draft
Conversation
Member
|
Can we also fix the |
Member
Author
Sure, I didn’t even spot that one. I’m confused why it doesn’t show as an error when the other deprecation did. |
Open
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR summary
Closes #31897. Turned out to not be as difficult as I thought.
Change the
TestSpectral.stimfixture method to be a class method, following pytest's deprecation. This actually makes the code a little more intuitive as shown by the deleted comment.I'm not sure why I had problems with the tests hanging when I tried yesterday, but it was fine on a different machine today 🤷♀️
AI Disclosure
No AI used.
PR checklist