WIP: Fix floating-point precision affecting GridSpec bottom and right#31703
Draft
ayshih wants to merge 1 commit into
Draft
WIP: Fix floating-point precision affecting GridSpec bottom and right#31703ayshih wants to merge 1 commit into
ayshih wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR summary
Currently, due to floating-point precision,
GridSpechas the quirk that the returned bottom and right might not exactly match the parameter-specified bottom and right.For example, for a single subplot and default parameters, the axes bottom should be 0.11 and the axes top should 0.88, but the axes bottom ends up being off by one floating-point tick:
That's because
0.88 - (0.88 - 0.11)gets computed as0.10999999999999999and not0.11.This PR forces the
GridSpec-returned bottom and right to be the parameter-specified bottom and right:AI Disclosure
No AI was used
PR checklist