BLD: Unpin setuptools-scm again#31569
Draft
QuLogic wants to merge 1 commit into
Draft
Conversation
The upstream issue pypa/setuptools-scm#1314 was fixed some time ago.
Member
Author
|
Hmm, looks like there's a deprecation as well, so we need #31387. @tacaswell |
Member
|
setuptools-scm 10.0.5 was released 1 month ago. Is that long enough for us to make a hard update to setuptools-scm>=10.0.5? If not we should wait until we can do the hard update and change in #31387. IMHO version gating to support <10 and >=10 is not worth the effort. |
Member
Author
|
We're a bit more lenient on SPEC 0 with build dependencies, I think, but 1 month may still be too short. |
Member
Author
|
In the meantime, I'll add a note that setuptools-scm may be unpinned for downstreams: #31677 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR summary
The upstream issue pypa/setuptools-scm#1314 was fixed some time ago.
AI Disclosure
Nada
PR checklist