You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
For historic reasons, Scales take the axis as the first parameter. It's use is discouraged and none of our own scales actually use it at least since #12831.
To simplify our code, we should get rid of that parameter.
Proposed fix
Do we know whether
downstream libraries add their own Scales via register_scale()?
user will directly instantiate our own Scale classes?
If so we need the full deprecation machinery:
Make scale_factory work with scales have or have not an initial axis parameter. Either by try-except with/without this parameter or by introspecting the signature.
Summary
For historic reasons, Scales take the axis as the first parameter. It's use is discouraged and none of our own scales actually use it at least since #12831.
To simplify our code, we should get rid of that parameter.
Proposed fix
Do we know whether
register_scale()?If so we need the full deprecation machinery:
scale_factorywork with scales have or have not an initialaxisparameter. Either by try-except with/without this parameter or by introspecting the signature.register_scaleand warn if they still have the axis argument.axisparameter by adding a suitable decorator to their init functions. - Refactoring: Removing axis parameter from scales #29988Otherwise, we can simplify the transition.
--
Edit: Both questions are yes, so we need the full deprecation mechanism.