FIX: Add a 0-length timer to allow fast animations to redraw on macosx

greglucas · greglucas · commit 8febf48a2397 · 2022-01-08T09:48:06.000-07:00
The macosx backend would not update on flush_events calls due to the
loop being run too fast for the view to update properly in the NSApp.
Fix that by adding an unnoticeable RunLoop timer slowdown that
allows the app to see the changes.
diff --git a/src/_macosx.m b/src/_macosx.m
@@ -385,6 +385,9 @@ static CGFloat _get_device_scale(CGContextRef cr)
 static PyObject*
 FigureCanvas_flush_events(FigureCanvas* self)
 {
+    // We need to interrupt the runloop very briefly to allow the view to be
+    // displayed when used in a fast updating animation
+    [[NSRunLoop currentRunLoop] runUntilDate:[NSDate dateWithTimeIntervalSinceNow:0.0]];
     [self->view displayIfNeeded];
     Py_RETURN_NONE;
 }

Original file line number	Diff line number	Diff line change
`@@ -385,6 +385,9 @@ static CGFloat _get_device_scale(CGContextRef cr)`
`385`	`385`	`static PyObject*`
`386`	`386`	`FigureCanvas_flush_events(FigureCanvas* self)`
`387`	`387`	`{`
	`388`	`+ // We need to interrupt the runloop very briefly to allow the view to be`
	`389`	`+ // displayed when used in a fast updating animation`
	`390`	`+ [[NSRunLoop currentRunLoop] runUntilDate:[NSDate dateWithTimeIntervalSinceNow:0.0]];`
`388`	`391`	`[self->view displayIfNeeded];`
`389`	`392`	`Py_RETURN_NONE;`
`390`	`393`	`}`