remove '*_range*' test, add else block

billbrod · billbrod · commit 7e4e832d2ee5 · 2026-04-08T10:35:10.000-04:00
diff --git a/lib/matplotlib/tests/test_sphinxext.py b/lib/matplotlib/tests/test_sphinxext.py
@@ -276,7 +276,7 @@ def plot_file(num, suff=''):
                                                    "*nonmatch*",
                                                    "range*", "range6*",
                                                    "index*,range*", "*",
-                                                   "*_range*", "*script*"])
+                                                   "*script*"])
 def test_plot_exclude_patterns(tmp_path, plot_exclude_patterns):
     # test that modifying plot_exclude_patterns in config leads to skipping files
     shutil.copyfile(tinypages / 'conf.py', tmp_path / 'conf.py')
@@ -359,10 +359,5 @@ def test_plot_exclude_patterns(tmp_path, plot_exclude_patterns):
         assert not (img_dir / "range6_range6.png").exists()
         assert not (img_dir / "range6_range10.png").exists()
         assert not (img_dir / "range4.png").exists()
-    # we match against the relative path, not the function name, so this doesn't match
-    # anything
-    elif plot_exclude_patterns == "*_range*":
-        assert (img_dir / "index-1.png").exists()
-        assert (img_dir / "range6_range6.png").exists()
-        assert (img_dir / "range6_range10.png").exists()
-        assert (img_dir / "range4.png").exists()
+    else:
+        raise ValueError(f"unsure how to check {plot_exclude_patterns=}")
