Removed unneccacery notes from test_rcparams.py

NoyHanan · NoyHanan · commit 21a74f49e67d · 2023-05-11T08:11:24.000+03:00
diff --git a/lib/matplotlib/rcsetup.py b/lib/matplotlib/rcsetup.py
@@ -733,24 +733,24 @@ def validate_legend_loc(loc):
     loc : str | int | (float, float) or raise ValueError exception
         The location of the legend.
     """
-    valid = [
+    valid = {
         "best",
         "upper right", "upper left", "lower left", "lower right", "right",
         "center left", "center right", "lower center", "upper center",
         "center"
-    ]
-    valid = {k: k for k in valid}
+    }
+
     key = "legend.loc"
     msg = (f"{loc!r} is not a valid value for {key}; supported values "
-           f"are {[*valid.values()]} | tuple(float, float) "
+           f"are {', '.join(valid)} | tuple(float, float) "
            f"| str(tuple(float, float))")
 
     if isinstance(loc, int):
         return loc
     if isinstance(loc, str):
         loc = loc.lower()
         if loc in valid:
-            return valid[loc]
+            return loc
         if (loc.startswith('"') and loc.endswith('"')
             or loc.startswith("'") and loc.endswith("'")) \
                 and loc[1:-1] in valid:
diff --git a/lib/matplotlib/tests/test_rcparams.py b/lib/matplotlib/tests/test_rcparams.py
@@ -591,12 +591,6 @@ def test_deprecation(monkeypatch):
     # suppress_matplotlib_deprecation_warning, rather than any explicit check.
 
 
-# def test_rcparams_legend_loc():
-#     value = (0.9, .7)
-#     match_str = f"{value} is not a valid value for legend.loc;"
-#     with pytest.raises(ValueError, match=re.escape(match_str)):
-#         mpl.RcParams({'legend.loc': value})
-
 @pytest.mark.parametrize('value', [
     1,
     (0.9, .7),
