Always use the actual x-height instead of what the font tells us. [skip ci]

tfpf · tfpf · commit 0e7bf545c9b3 · 2022-06-15T14:41:05.000+05:30
diff --git a/lib/matplotlib/_mathtext.py b/lib/matplotlib/_mathtext.py
@@ -254,16 +254,10 @@ def _get_info(self, fontname, font_class, sym, fontsize, dpi):
         return result
 
     def get_xheight(self, fontname, fontsize, dpi):
-        font = self._get_font(fontname)
-        font.set_size(fontsize, dpi)
-        pclt = font.get_sfnt_table('pclt')
-        if pclt is None:
-            # Some fonts don't store the xHeight, so we do a poor man's xHeight
-            metrics = self.get_metrics(
-                fontname, mpl.rcParams['mathtext.default'], 'x', fontsize, dpi)
-            return metrics.iceberg
-        xHeight = (pclt['xHeight'] / 64.0) * (fontsize / 12.0) * (dpi / 100.0)
-        return xHeight
+        # Some fonts report the wrong x-height, so we do a poor man's x-height.
+        metrics = self.get_metrics(
+            fontname, mpl.rcParams['mathtext.default'], 'x', fontsize, dpi)
+        return metrics.iceberg
 
     def get_underline_thickness(self, font, fontsize, dpi):
         # This function used to grab underline thickness from the font
