Tim Peters fixed PR#75: very long lines cause incorrect tracebacks.

guido · guido · commit e5001fb3bb8e · 1999-09-18T20:49:39.000Z
git-svn-id: http://svn.python.org/projects/python/trunk@13833 6015fed2-1504-0410-9fe1-9d1591cc4771
diff --git a/Python/traceback.c b/Python/traceback.c
@@ -197,8 +197,17 @@ tb_displayline(f, filename, lineno, name)
 	if (xfp == NULL || err != 0)
 		return err;
 	for (i = 0; i < lineno; i++) {
-		if (fgets(linebuf, sizeof linebuf, xfp) == NULL)
-			break;
+		char* pLastChar = &linebuf[sizeof(linebuf)-2];
+		do {
+			*pLastChar = '\0';
+			if (fgets(linebuf, sizeof linebuf, xfp) == NULL)
+				break;
+			/* fgets read *something*; if it didn't get as
+			   far as pLastChar, it must have found a newline
+			   or hit the end of the file;	if pLastChar is \n,
+			   it obviously found a newline; else we haven't
+			   yet seen a newline, so must continue */
+		} while (*pLastChar != '\0' && *pLastChar != '\n');
 	}
 	if (i == lineno) {
 		char *p = linebuf;
