Fixed clone test

implausible · implausible · commit 90f88a63a8a0 · 2015-07-29T12:06:34.000-07:00
Added first pass check, then return default credentials for all other occurences. The credentials will pass back the credentials we want it to, then pass back a default credentials set for all other occurences. Thus stopping the credentials cb loop.
diff --git a/test/tests/clone.js b/test/tests/clone.js
@@ -151,21 +151,28 @@ describe("Clone", function() {
     });
   });
 
-  it("will not segfault when accessing a url without username", function() {
+  it.only("will not segfault when accessing a url without username", function(){
     var url = "https://github.com/nodegit/private";
 
+    var firstPass = true;
+
     return Clone(url, clonePath, {
       fetchOpts: {
         callbacks: {
           certificateCheck: function() {
             return 1;
           },
           credentials: function() {
-            return NodeGit.Cred.userpassPlaintextNew("fake-token",
-              "x-oauth-basic");
+            if (firstPass) {
+              firstPass = false;
+              return NodeGit.Cred.userpassPlaintextNew("fake-token",
+                "x-oauth-basic");
+            } else {
+              return NodeGit.Cred.defaultNew();
+            }
           }
         }
       }
-    }).catch(function unhandledError() { });
+    }).catch(function(reason) { });
   });
 });
diff --git a/test/tests/remote.js b/test/tests/remote.js
@@ -194,13 +194,16 @@ describe("Remote", function() {
         var firstPass = true;
         var options = {
           callbacks: {
-            credentials:function(url, userName) {
+            credentials: function(url, userName) {
               if (firstPass) {
+                firstPass = false;
                 if (url.indexOf("https") === -1) {
                   return NodeGit.Cred.sshKeyFromAgent(userName);
                 } else {
-                    return NodeGit.Cred.defaultNew();
+                    return NodeGit.Cred.userpassPlaintextNew(userName, "");
                 }
+              } else {
+                return NodeGit.Cred.defaultNew();
               }
             },
             certificateCheck: function() {
