Sorting exposed with commit.history(sort.Time)

nkallen · nkallen · commit 7cca0eb67a97 · 2013-09-05T20:40:04.000-04:00
diff --git a/example/walk-history.js b/example/walk-history.js
@@ -1,5 +1,6 @@
 var git = require('../'),
-    path = require('path');
+    path = require('path'),
+    sort = git.RevWalk.Sort;
 
 // This code walks the history of the master branch and prints results
 // that look very similar to calling `git log` from the command line
@@ -11,7 +12,7 @@ git.Repo.open(path.resolve(__dirname, '../.git'), function(error, repo) {
     if (error) throw error;
 
     // History returns an event.
-    var history = branch.history();
+    var history = branch.history(sort.Time);
 
     // History emits 'commit' event for each commit in the branch's history
     history.on('commit', function(commit) {
diff --git a/lib/commit.js b/lib/commit.js
@@ -66,6 +66,8 @@ Commit.prototype.history = function() {
 
   var oid = this.oid();
   var revwalk = this.repo.createRevWalk();
+  revwalk.sorting.apply(revwalk, arguments);
+
   var commits = [];
   event.start = function() {
     revwalk.walk(oid, function commitRevWalk(error, commit) {
diff --git a/lib/revwalk.js b/lib/revwalk.js
@@ -17,7 +17,7 @@ RevWalk.Sort = {
  * Set the sort order for the revwalk. This function takes variable arguments
  * like `revwalk.sorting(git.RevWalk.Topological, git.RevWalk.Reverse).`
  *
- * @param {Number} 
+ * @param {Number} sort
  */
 RevWalk.prototype.sorting = function() {
   var sort = 0;

Original file line number	Diff line number	Diff line change
`@@ -17,7 +17,7 @@ RevWalk.Sort = {`
`17`	`17`	`* Set the sort order for the revwalk. This function takes variable arguments`
`18`	`18`	* like `revwalk.sorting(git.RevWalk.Topological, git.RevWalk.Reverse).`
`19`	`19`	`*`
`20`		`- * @param {Number}`
	`20`	`+ * @param {Number} sort`
`21`	`21`	`*/`
`22`	`22`	`RevWalk.prototype.sorting = function() {`
`23`	`23`	`var sort = 0;`