Fixing some memory leaks

nkallen · nkallen · commit 79f111573fe9 · 2013-09-03T17:34:49.000-04:00
diff --git a/src/oid.cc b/src/oid.cc
@@ -112,6 +112,7 @@ Handle<Value> GitOid::Sha(const Arguments& args) {
 
   Handle<Value> to;
     to = String::New(result);
+  free(result);
   return scope.Close(to);
 }
 
diff --git a/src/patch.cc b/src/patch.cc
@@ -319,6 +319,7 @@ Handle<Value> GitPatch::ToString(const Arguments& args) {
 
   Handle<Value> to;
     to = String::New(string);
+  free(string);
   return scope.Close(to);
 }
 
diff --git a/templates/convertToV8.cc.ejs b/templates/convertToV8.cc.ejs
@@ -5,6 +5,9 @@
 <% } else { -%>
   to = String::New(<%- toName %>);
 <% } -%>
+<% if (to.freeFunctionName) { -%>
+  <%- to.freeFunctionName %>(<%- toName %>);
+<% } -%>
 <% } else if (isV8Value(to.cppClassName)) { -%>
   to = <%- to.cppClassName %>::New(<%- toName %>);
 <% } else if (to.cppClassName == "External") { -%>
diff --git a/v0.18.0.json b/v0.18.0.json
@@ -3147,7 +3147,8 @@
             "cppClassName": "String",
             "jsClassName": "String",
             "isReturn": true,
-            "comment": "Allocated string; caller must free."
+            "comment": "Allocated string; caller must free.",
+            "freeFunctionName": "free"
           },
           {
             "name": "patch",
@@ -7622,7 +7623,8 @@
           "cType": "char *",
           "cppClassName": "String",
           "comment": "the c-string; NULL if memory is exhausted. Caller must deallocate the string with git__free().",
-          "jsClassName": "String"
+          "jsClassName": "String",
+          "freeFunctionName": "free"
         },
         "description": "<p>Format a git_oid into a newly allocated c-string.</p>\n"
       },

Original file line number	Diff line number	Diff line change
`@@ -112,6 +112,7 @@ Handle<Value> GitOid::Sha(const Arguments& args) {`
`112`	`112`
`113`	`113`	`Handle<Value> to;`
`114`	`114`	`to = String::New(result);`
	`115`	`+ free(result);`
`115`	`116`	`return scope.Close(to);`
`116`	`117`	`}`
`117`	`118`
Original file line number	Diff line number	Diff line change
`@@ -319,6 +319,7 @@ Handle<Value> GitPatch::ToString(const Arguments& args) {`
`319`	`319`
`320`	`320`	`Handle<Value> to;`
`321`	`321`	`to = String::New(string);`
	`322`	`+ free(string);`
`322`	`323`	`return scope.Close(to);`
`323`	`324`	`}`
`324`	`325`