Skip to content

Commit 1af7369

Browse files
facelegfaceleg
committed
Use new when creating errors
1 parent 760fc58 commit 1af7369

File tree

9 files changed

+15
-17
lines changed

9 files changed

+15
-17
lines changed

‎lib/blob.js‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ var git = require('../'),
1010
*/
1111
var Blob = function(rawRepo, rawBlob) {
1212
if(!(rawRepo instanceof git.raw.Repo)) {
13-
throw git.error('First parameter for Blob must be a raw repo');
13+
throw new git.error('First parameter for Blob must be a raw repo');
1414
}
1515
this.rawRepo = rawRepo;
1616

‎lib/commit.js‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ var git = require( '../' ),
1111
*/
1212
var Commit = function(rawRepo, rawCommit) {
1313
if (!(rawRepo instanceof git.raw.Repo)) {
14-
throw git.error('First parameter for Commit must be a raw repo');
14+
throw new git.error('First parameter for Commit must be a raw repo');
1515
}
1616

1717
this.rawRepo = rawRepo;

‎lib/reference.js‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ var git = require('../'),
1010
*/
1111
var Reference = function(rawRepo, rawReference) {
1212
if (!(rawRepo instanceof git.raw.Repo)) {
13-
throw git.error('First parameter for Reference must be a raw repo');
13+
throw new git.error('First parameter for Reference must be a raw repo');
1414
}
1515
this.rawRepo = rawRepo;
1616

‎lib/repo.js‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ var Repo = function() {
1313
*/
1414
Repo.prototype.open = function(directory, callback) {
1515
if (typeof callback === 'undefined') {
16-
throw git.error('Callback is required and must be a Function');
16+
throw new git.error('Callback is required and must be a Function');
1717
}
1818
var self = this;
1919
self.rawRepo.open(directory, function openRepository(error, rawRepo) {

‎lib/revwalk.js‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ var git = require('../'),
1010
*/
1111
var RevWalk = function(rawRepo, rawRevWalk) {
1212
if (!(rawRepo instanceof git.raw.Repo)) {
13-
throw git.error('First parameter for RevWalk must be a raw repo');
13+
throw new git.error('First parameter for RevWalk must be a raw repo');
1414
}
1515
this.rawRepo = rawRepo;
1616

@@ -60,7 +60,7 @@ RevWalk.prototype.walk = function(oid, callback) {
6060

6161
self.rawRevWalk.next(function revWalkNext(error, oid, walkOver) {
6262
if(error) {
63-
callback(git.error(error), index, commit);
63+
callback(new git.error(error.message, error.code), index, commit);
6464
return;
6565
}
6666

@@ -72,7 +72,7 @@ RevWalk.prototype.walk = function(oid, callback) {
7272

7373
(new git.commit(self.rawRepo)).lookup(oid, function revWalkCommitLookup(error, commit) {
7474
if(error) {
75-
callback(git.error(error), index, commit);
75+
callback(new git.error(error.message, error.code), index, commit);
7676
return;
7777
}
7878
if(callback(null, index, commit) === false) {

‎lib/tree.js‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ var git = require('../'),
1111
*/
1212
var Tree = function(rawRepo, rawTree) {
1313
if(!(rawRepo instanceof git.raw.Repo)) {
14-
throw git.error('First parameter for Tree must be a raw repo');
14+
throw new git.error('First parameter for Tree must be a raw repo');
1515
}
1616
this.rawRepo = rawRepo;
1717

@@ -84,7 +84,7 @@ Tree.prototype.walk = function(blobsOnly) {
8484
* @param {GitError|null} error An error object if there was an issue, null otherwise.
8585
* @param {Entry[]} entries The tree entries.
8686
*/
87-
event.emit('end', error ? git.error(error) : null, entries);
87+
event.emit('end', error ? new git.error(error.message, error.code) : null, entries);
8888
});
8989

9090
return event;

‎lib/tree_entry.js‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -19,11 +19,11 @@ var fileModeIsDirectory = function(fileMode, instance) {
1919
*/
2020
var TreeEntry = function(rawRepo, rawTreeEntry) {
2121
if(!(rawRepo instanceof git.raw.Repo)) {
22-
throw git.error('First parameter for Tree Entry must be a raw repo', 0);
22+
throw new git.error('First parameter for Tree Entry must be a raw repo', 0);
2323
}
2424

2525
if(!(rawTreeEntry instanceof git.raw.TreeEntry)) {
26-
throw git.error('Second parameter for Tree Entry must be a raw tree entry', 0);
26+
throw new git.error('Second parameter for Tree Entry must be a raw tree entry', 0);
2727
}
2828

2929
this.rawRepo = rawRepo;

‎lib/utilities.js‎

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,16 +4,17 @@ var git = require('../');
44
* Check if error is null, if it is not, convert it to a GitError and call
55
* the callback.
66
*
7-
* @param {Object} error
7+
* @param {Object} error
88
* @param {Function} callback
9+
*
910
* @return {Boolean} True if the error was null, false otherwise.
1011
*/
1112
exports.success = function(error, callback) {
1213
if (error) {
1314
if (error instanceof git.error) {
1415
callback(error);
1516
} else {
16-
callback(git.error(error));
17+
callback(new git.error(error.message, error.code));
1718
}
1819
return false;
1920
}

‎test/utilities.js‎

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -14,10 +14,7 @@ exports.successNoError = function(test){
1414
*/
1515
exports.successError = function(test){
1616
test.expect(3);
17-
utilities.success(git.error({
18-
code: git.raw.Error.codes.GITERR_INVALID,
19-
message: 'Message'
20-
}), function(error) {
17+
utilities.success(new git.error('Message', git.raw.Error.codes.GITERR_INVALID), function(error) {
2118
test.notEqual(error, null, 'Error should not be null');
2219
test.equal(error.code, git.raw.Error.codes.GITERR_INVALID, 'Error code should match input');
2320
test.equal(error.message, 'Message', 'Error message should match input');

0 commit comments

Comments
 (0)