From d727a5098eb9981ae00b07731f0206762ed6a22e Mon Sep 17 00:00:00 2001 From: Stefanos Kalantzis Date: Fri, 5 Jun 2026 11:47:38 +0200 Subject: [PATCH] remove multiple calls of getters where possible by using a local variable --- .../model/CollectionAssignmentBuilder.java | 42 +- .../ap/internal/model/PropertyMapping.java | 17 + .../ap/internal/model/TypeConversion.java | 8 + .../model/assignment/ArrayCopyWrapper.java | 4 +- .../ap/internal/model/common/SourceRHS.java | 17 +- .../bugs/_3591/ContainerBeanMapperImpl.java | 5 +- .../DomainDtoWithNcvsAlwaysMapperImpl.java | 50 +- .../DomainDtoWithNvmsDefaultMapperImpl.java | 50 +- .../_913/DomainDtoWithNvmsNullMapperImpl.java | 50 +- .../DomainDtoWithPresenceCheckMapperImpl.java | 50 +- .../numbers/SourceTargetMapperImpl.java | 215 +++-- .../updatemethods/CompanyMapper1Impl.java | 10 +- .../bugs/_1576/java8/Issue1576MapperImpl.java | 32 +- .../ap/test/bugs/_1685/UserMapperImpl.java | 39 +- .../bugs/_3591/ContainerBeanMapperImpl.java | 5 +- .../DomainDtoWithNcvsAlwaysMapperImpl.java | 50 +- .../DomainDtoWithNvmsDefaultMapperImpl.java | 50 +- .../_913/DomainDtoWithNvmsNullMapperImpl.java | 50 +- .../DomainDtoWithPresenceCheckMapperImpl.java | 50 +- .../basic/ConditionalMethodInMapperImpl.java | 9 +- ...WithSourceParameterAndValueMapperImpl.java | 9 +- .../OptionalSourceTargetMapperImpl.java | 688 +++++++++------ .../java8time/SourceTargetMapperImpl.java | 786 +++++++++++------- .../SourceTargetMapperImpl.java | 36 +- .../SourceTargetMapperImpl.java | 50 +- .../numbers/SourceTargetMapperImpl.java | 215 +++-- .../string/SourceTargetMapperImpl.java | 136 +-- .../BeanWithInnerEnumMapperImpl.java | 14 +- .../UserDtoUpdateMapperSmartImpl.java | 45 +- .../ChartEntryToArtistUpdateImpl.java | 31 +- .../JSpecifyNonNullParamMapperImpl.java | 9 +- .../jspecify/JSpecifyNullCheckMapperImpl.java | 9 +- .../JSpecifyOverridesStrategyMapperImpl.java | 19 +- .../jspecify/JSpecifyUpdateMapperImpl.java | 19 +- ...llMarkedMapperImpl_withoutPackageInfo.java | 9 +- .../OptionalBeforeAfterMapperImpl.java | 14 +- ...nalNestedPresenceCheckFirstMapperImpl.java | 7 +- .../OptionalNullCheckAlwaysMapperImpl.java | 19 +- .../sametype/OptionalSameTypeMapperImpl.java | 34 +- .../updatemethods/CompanyMapper1Impl.java | 10 +- .../test/updatemethods/CompanyMapperImpl.java | 5 +- .../updatemethods/OrganizationMapperImpl.java | 5 +- .../selection/DepartmentMapperImpl.java | 12 +- .../selection/OrganizationMapper1Impl.java | 6 +- .../selection/OrganizationMapper2Impl.java | 6 +- .../selection/OrganizationMapper3Impl.java | 6 +- 46 files changed, 1817 insertions(+), 1185 deletions(-) diff --git a/processor/src/main/java/org/mapstruct/ap/internal/model/CollectionAssignmentBuilder.java b/processor/src/main/java/org/mapstruct/ap/internal/model/CollectionAssignmentBuilder.java index db9e012d78..c236df81ea 100644 --- a/processor/src/main/java/org/mapstruct/ap/internal/model/CollectionAssignmentBuilder.java +++ b/processor/src/main/java/org/mapstruct/ap/internal/model/CollectionAssignmentBuilder.java @@ -37,7 +37,7 @@ /** * A builder that is used for creating an assignment to a collection. - * + *

* The created assignments to the following null checks: *

- * + *

* A local-var-null-check is needed in the following cases: * *