Simplify fail in assertCheckstyleRules (#4003)

hduelme · web-flow · commit 66625e61a4c4 · 2026-03-04T16:01:38.000+01:00
diff --git a/processor/src/test/java/org/mapstruct/ap/testutil/runner/CompilingExtension.java b/processor/src/test/java/org/mapstruct/ap/testutil/runner/CompilingExtension.java
@@ -55,6 +55,7 @@
 import org.xml.sax.InputSource;
 
 import static org.assertj.core.api.Assertions.assertThat;
+import static org.assertj.core.api.Assertions.fail;
 import static org.junit.platform.commons.support.AnnotationSupport.findAnnotation;
 import static org.junit.platform.commons.support.AnnotationSupport.findRepeatableAnnotations;
 
@@ -237,8 +238,7 @@ private void assertCheckstyleRules() throws Exception {
             int errors = checker.process( findGeneratedFiles( new File( sourceOutputDir ) ) );
             if ( errors > 0 ) {
                 String errorLog = errorStream.toString( "UTF-8" );
-                assertThat( true ).describedAs( "Expected checkstyle compliant output, but got errors:\n" + errorLog )
-                                  .isEqualTo( false );
+                fail( "Expected checkstyle compliant output, but got errors:\n" + errorLog );
             }
         }
     }

Original file line number	Diff line number	Diff line change
`@@ -55,6 +55,7 @@`
`55`	`55`	`import org.xml.sax.InputSource;`
`56`	`56`
`57`	`57`	`import static org.assertj.core.api.Assertions.assertThat;`
	`58`	`+import static org.assertj.core.api.Assertions.fail;`
`58`	`59`	`import static org.junit.platform.commons.support.AnnotationSupport.findAnnotation;`
`59`	`60`	`import static org.junit.platform.commons.support.AnnotationSupport.findRepeatableAnnotations;`
`60`	`61`
`@@ -237,8 +238,7 @@ private void assertCheckstyleRules() throws Exception {`
`237`	`238`	`int errors = checker.process( findGeneratedFiles( new File( sourceOutputDir ) ) );`
`238`	`239`	`if ( errors > 0 ) {`
`239`	`240`	`String errorLog = errorStream.toString( "UTF-8" );`
`240`		`- assertThat( true ).describedAs( "Expected checkstyle compliant output, but got errors:\n" + errorLog )`
`241`		`- .isEqualTo( false );`
	`241`	`+ fail( "Expected checkstyle compliant output, but got errors:\n" + errorLog );`
`242`	`242`	`}`
`243`	`243`	`}`
`244`	`244`	`}`