ensure we only generate compile commands for a correct match

Dane Springmeyer · Dane Springmeyer · commit 4a906fea1282 · 2018-06-27T12:51:14.000-07:00
diff --git a/scripts/generate_compile_commands.py b/scripts/generate_compile_commands.py
@@ -6,7 +6,7 @@
 import re
 
 # Script to generate compile_commands.json based on Makefile output
-# Works by accepting Makefile output from stdin, parsing it, and 
+# Works by accepting Makefile output from stdin, parsing it, and
 # turning into json records. These are then printed to stdout.
 # More details on the compile_commands format at:
 # https://clang.llvm.org/docs/JSONCompilationDatabase.html
@@ -28,11 +28,12 @@ def generate():
     for line in sys.stdin.readlines():
         if TOKEN_DENOTING_COMPILED_FILE in line:
             match = matcher.match(line)
-            compile_commands.append({
-                "directory": build_dir,
-                "command": line.strip(),
-                "file": os.path.normpath(os.path.join(build_dir,match.group(2)))
-            })
+            if match:
+                compile_commands.append({
+                    "directory": build_dir,
+                    "command": line.strip(),
+                    "file": os.path.normpath(os.path.join(build_dir,match.group(2)))
+                })
     print(json.dumps(compile_commands,indent=4))
 
 if __name__ == '__main__':
