Fix CI triggers with dynamic config (DataDog#5773)

smola · web-flow · commit bb95c7a20fcc · 2023-08-24T15:34:04.000+02:00
Regular triggers do not play well with dynamic config in Circle CI. We need to use pipeline triggers at: https://app.circleci.com/settings/project/github/DataDog/dd-trace-java/triggers
diff --git a/.circleci/config.continue.yml.j2 b/.circleci/config.continue.yml.j2
@@ -32,6 +32,13 @@ profiling_modules: &profiling_modules "dd-java-agent/agent-profiling"
 default_system_tests_commit: &default_system_tests_commit 9659a5e409cf8bacabd739b6af07c5f03c9bcbd6
 
 parameters:
+  nightly:
+    type: boolean
+    default: false
+  weekly:
+    type: boolean
+    default: false
+
   gradle_flags:
     # Using no-daemon is important for the caches to be in a consistent state
     type: string
@@ -1248,32 +1255,18 @@ build_test_jobs: &build_test_jobs
       stage: required
 
 workflows:
+{% if is_regular %}
   build_test:
     jobs:
       *build_test_jobs
-
+{% endif %}
+{% if is_nightly %}
   nightly:
-    triggers:
-      - schedule:
-          # Run this job at 00:35 UTC every day
-          # The 30 minutes will allow weekly to finish before nightly is triggered on Mondays
-          cron: "35 0 * * *"
-          filters:
-            branches:
-              only:
-                - master
     jobs:
       *build_test_jobs
-
+{% endif %}
+{% if is_weekly %}
   weekly:
-    triggers:
-      - schedule:
-          # Run this job at 00:05 UTC every Monday
-          cron: "5 0 * * 1"
-          filters:
-            branches:
-              only:
-                - master
     jobs:
       # This will rebuild a main caches with a new timestamp from a clean slate
       - build_clean_cache:
@@ -1301,3 +1294,4 @@ workflows:
           name: build_cache_profiling
           gradleTarget: :profilingTest
           cacheType: profiling
+{% endif %}
diff --git a/.circleci/config.yml b/.circleci/config.yml
@@ -1,6 +1,13 @@
 version: 2.1
 setup: true
 python310_image: &python310_image cimg/python:3.10
+parameters:
+  nightly:
+    type: boolean
+    default: false
+  weekly:
+    type: boolean
+    default: false
 orbs:
   continuation: circleci/continuation@0.1.2
 executors:
@@ -18,7 +25,10 @@ jobs:
           command: pip3 install jinja2 requests
       - run:
           name: Generate config
-          command: .circleci/render_config.py
+          command: >-
+            CIRCLE_IS_NIGHTLY="<< pipeline.parameters.nightly >>"
+            CIRCLE_IS_WEEKLY="<< pipeline.parameters.weekly >>"
+            .circleci/render_config.py
       - continuation/continue:
           configuration_path: .circleci/config.continue.yml
 workflows:
diff --git a/.circleci/render_config.py b/.circleci/render_config.py
@@ -71,7 +71,16 @@
     all_jdks = ALWAYS_ON_JDKS | (MASTER_ONLY_JDKS & labels)
 nocov_jdks = [j for j in all_jdks if j != "8"]
 
+# Is this a nightly or weekly build? These environment variables are set in
+# config.yml based on pipeline parameters.
+is_nightly = os.environ.get("CIRCLE_IS_NIGHTLY", "false") == "true"
+is_weekly = os.environ.get("CIRCLE_IS_WEEKLY", "false") == "true"
+is_regular = not is_nightly and not is_weekly
+
 vars = {
+    "is_nightly": is_nightly,
+    "is_weekly": is_weekly,
+    "is_regular": is_regular,
     "all_jdks": all_jdks,
     "nocov_jdks": nocov_jdks,
     "flaky": branch == "master" or "flaky" in labels or "all" in labels,
