- Added unit tests for comparison operators (except compare())

blep · blep · commit fb17080142ed · 2011-05-02T16:53:10.000Z
- Fixed Value::operator &lt;= implementation (had the semantic of operator &gt;=). Found when addigin unit tests for comparison operators.
diff --git a/NEWS.txt b/NEWS.txt
@@ -86,6 +86,9 @@
     
   - Bug #3139678: stack buffer overflow when parsing a double with a
     length of 32 characters.
+	
+  - Fixed Value::operator <= implementation (had the semantic of operator >=).
+    Found when addigin unit tests for comparison operators.
     
 * License
   
diff --git a/src/lib_json/json_value.cpp b/src/lib_json/json_value.cpp
@@ -600,7 +600,7 @@ Value::operator <( const Value &other ) const
 bool 
 Value::operator <=( const Value &other ) const
 {
-   return !(other > *this);
+   return !(other < *this);
 }
 
 bool 

Original file line number	Diff line number	Diff line change
`@@ -600,7 +600,7 @@ Value::operator <( const Value &other ) const`
`600`	`600`	`bool`
`601`	`601`	`Value::operator <=( const Value &other ) const`
`602`	`602`	`{`
`603`		`- return !(other > *this);`
	`603`	`+ return !(other < *this);`
`604`	`604`	`}`
`605`	`605`
`606`	`606`	`bool`