patch 9.1.1023: Coverity complains about dereferencing NULL pointer

chrisbra · chrisbra · commit a9f77be9223f · 2025-01-16T19:06:57.000+01:00
Problem:  Coverity complains about dereferencing NULL pointer
Solution: Verify curdiff is not null before dereferencing it

closes: #16437

Signed-off-by: Christian Brabandt &lt;cb@256bit.org&gt;
diff --git a/src/diff.c b/src/diff.c
@@ -2062,8 +2062,11 @@ count_filler_lines_and_topline(
 	else
 	{
 	    (*linesfiller) = 0;
-	    ch_virtual_lines = get_max_diff_length(curdif);
-	    isfiller = (curdif->df_count[toidx] ? FALSE : TRUE);
+	    if (curdif)
+	    {
+		ch_virtual_lines = get_max_diff_length(curdif);
+		isfiller = (curdif->df_count[toidx] ? FALSE : TRUE);
+	    }
 	    if (isfiller)
 	    {
 		while (curdif && curdif->df_next &&
diff --git a/src/version.c b/src/version.c
@@ -704,6 +704,8 @@ static char *(features[]) =
 
 static int included_patches[] =
 {   /* Add new patch number below this line */
+/**/
+    1023,
 /**/
     1022,
 /**/

Original file line number	Diff line number	Diff line change
`@@ -2062,8 +2062,11 @@ count_filler_lines_and_topline(`
`2062`	`2062`	`else`
`2063`	`2063`	`{`
`2064`	`2064`	`(*linesfiller) = 0;`
`2065`		`- ch_virtual_lines = get_max_diff_length(curdif);`
`2066`		`- isfiller = (curdif->df_count[toidx] ? FALSE : TRUE);`
	`2065`	`+ if (curdif)`
	`2066`	`+ {`
	`2067`	`+ ch_virtual_lines = get_max_diff_length(curdif);`
	`2068`	`+ isfiller = (curdif->df_count[toidx] ? FALSE : TRUE);`
	`2069`	`+ }`
`2067`	`2070`	`if (isfiller)`
`2068`	`2071`	`{`
`2069`	`2072`	`while (curdif && curdif->df_next &&`