patch 9.0.1336: functions without arguments are not always declared properly

yegappan · brammool · commit a23a11b5bf03 · 2023-02-21T14:27:41.000Z
Problem:    Functions without arguments are not always declared properly.
Solution:   Use "(void)" instead of "()". (Yegappan Lakshmanan, closes #12031)
diff --git a/src/channel.c b/src/channel.c
@@ -4180,7 +4180,7 @@ channel_handle_events(int only_keep_open)
  * Return TRUE when there is any channel with a keep_open flag.
  */
     int
-channel_any_keep_open()
+channel_any_keep_open(void)
 {
     channel_T	*channel;
 
diff --git a/src/charset.c b/src/charset.c
@@ -1764,7 +1764,7 @@ skipwhite_and_nl(char_u *q)
  * columns (bytes) at the start of a given line
  */
     int
-getwhitecols_curline()
+getwhitecols_curline(void)
 {
     return getwhitecols(ml_get_curline());
 }
diff --git a/src/clipboard.c b/src/clipboard.c
@@ -257,7 +257,7 @@ start_global_changes(void)
  * right text.
  */
     static int
-is_clipboard_needs_update()
+is_clipboard_needs_update(void)
 {
     return clipboard_needs_update;
 }
diff --git a/src/crypt.c b/src/crypt.c
@@ -155,7 +155,7 @@ static cryptmethod_T cryptmethods[CRYPT_M_COUNT] = {
     // to avoid that a text file is recognized as encrypted.
 };
 
-#ifdef FEAT_SODIUM
+#if defined(FEAT_SODIUM) || defined(PROTO)
 typedef struct {
     size_t	    count;
     unsigned char   key[crypto_box_SEEDBYTES];
@@ -396,7 +396,7 @@ crypt_get_header_len(int method_nr)
  * Get maximum crypt method specific length of the file header in bytes.
  */
     int
-crypt_get_max_header_len()
+crypt_get_max_header_len(void)
 {
     int i;
     int max = 0;
diff --git a/src/debugger.c b/src/debugger.c
@@ -734,7 +734,7 @@ ex_debuggreedy(exarg_T *eap)
 }
 
     static void
-update_has_expr_breakpoint()
+update_has_expr_breakpoint(void)
 {
     int i;
 
@@ -751,7 +751,7 @@ update_has_expr_breakpoint()
  * Return TRUE if there is any expression breakpoint.
  */
     int
-debug_has_expr_breakpoint()
+debug_has_expr_breakpoint(void)
 {
     return has_expr_breakpoint;
 }
diff --git a/src/edit.c b/src/edit.c
@@ -4607,7 +4607,7 @@ ins_end(int c)
 }
 
     static void
-ins_s_left()
+ins_s_left(void)
 {
     int end_change = dont_sync_undo == FALSE; // end undoable change
 #ifdef FEAT_FOLDING
@@ -4676,7 +4676,7 @@ ins_right(void)
 }
 
     static void
-ins_s_right()
+ins_s_right(void)
 {
     int end_change = dont_sync_undo == FALSE; // end undoable change
 #ifdef FEAT_FOLDING
diff --git a/src/ex_docmd.c b/src/ex_docmd.c
@@ -1386,7 +1386,7 @@ do_cmdline(
  * Handle when "did_throw" is set after executing commands.
  */
     void
-handle_did_throw()
+handle_did_throw(void)
 {
     char	*p = NULL;
     msglist_T	*messages = NULL;
diff --git a/src/gui_gtk_x11.c b/src/gui_gtk_x11.c
@@ -463,7 +463,7 @@ alloc_resize_hist(int width, int height)
  * This list is empty when there are no outstanding resize requests.
  */
     static void
-clear_resize_hists()
+clear_resize_hists(void)
 {
 # ifdef ENABLE_RESIZE_HISTORY_LOG
     int		    i = 0;
@@ -516,7 +516,7 @@ match_stale_width_height(int width, int height)
 
 # if defined(EXITFREE)
     static void
-free_all_resize_hist()
+free_all_resize_hist(void)
 {
     clear_resize_hists();
     vim_free(latest_resize_hist);
diff --git a/src/gui_xim.c b/src/gui_xim.c
@@ -295,7 +295,7 @@ im_preedit_window_set_position(void)
 }
 
     static void
-im_preedit_window_open()
+im_preedit_window_open(void)
 {
     char *preedit_string;
 #if !GTK_CHECK_VERSION(3,16,0)
@@ -417,14 +417,14 @@ im_preedit_window_open()
 }
 
     static void
-im_preedit_window_close()
+im_preedit_window_close(void)
 {
     if (preedit_window != NULL)
 	gtk_widget_hide(preedit_window);
 }
 
     static void
-im_show_preedit()
+im_show_preedit(void)
 {
     im_preedit_window_open();
 
diff --git a/src/highlight.c b/src/highlight.c
@@ -469,7 +469,7 @@ init_highlight(
  * the user to override the color values. Only loaded once.
  */
     static void
-load_default_colors_lists()
+load_default_colors_lists(void)
 {
     // Lacking a default color list isn't the end of the world but it is likely
     // an inconvenience so users should know when it is missing.
diff --git a/src/if_lua.c b/src/if_lua.c
@@ -2736,7 +2736,7 @@ set_ref_in_lua(int copyID)
 }
 
     void
-update_package_paths_in_lua()
+update_package_paths_in_lua(void)
 {
     if (!lua_isopen())
 	return;
diff --git a/src/indent.c b/src/indent.c
@@ -1161,7 +1161,7 @@ preprocs_left(void)
  * Return TRUE if the conditions are OK for smart indenting.
  */
     int
-may_do_si()
+may_do_si(void)
 {
     return curbuf->b_p_si
 	&& !curbuf->b_p_cin
diff --git a/src/insexpand.c b/src/insexpand.c
@@ -2994,7 +2994,7 @@ ins_compl_mode(void)
  * one assigned yet.
  */
     static void
-ins_compl_update_sequence_numbers()
+ins_compl_update_sequence_numbers(void)
 {
     int		number = 0;
     compl_T	*match;
@@ -3457,7 +3457,7 @@ get_next_filename_completion(void)
  * Get the next set of command-line completions matching "compl_pattern".
  */
     static void
-get_next_cmdline_completion()
+get_next_cmdline_completion(void)
 {
     char_u	**matches;
     int		num_matches;
diff --git a/src/job.c b/src/job.c
@@ -885,7 +885,7 @@ job_still_useful(job_T *job)
  * Return TRUE when there is any running job that we care about.
  */
     int
-job_any_running()
+job_any_running(void)
 {
     job_T	*job;
 
@@ -1655,7 +1655,7 @@ init_prompt(int cmdchar_todo)
  * Return TRUE if the cursor is in the editable position of the prompt line.
  */
     int
-prompt_curpos_editable()
+prompt_curpos_editable(void)
 {
     return curwin->w_cursor.lnum == curbuf->b_ml.ml_line_count
 	&& curwin->w_cursor.col >= (int)STRLEN(prompt_text());
diff --git a/src/misc1.c b/src/misc1.c
@@ -1313,7 +1313,7 @@ free_users(void)
 
 #if defined(MSWIN) || defined(PROTO)
 /*
- * Initilize $VIM and $VIMRUNTIME when 'enc' is updated.
+ * Initialize $VIM and $VIMRUNTIME when 'enc' is updated.
  */
     void
 init_vimdir(void)
@@ -2777,7 +2777,7 @@ restore_v_event(dict_T *v_event, save_v_event_T *sve)
  * Fires a ModeChanged autocmd event if appropriate.
  */
     void
-may_trigger_modechanged()
+may_trigger_modechanged(void)
 {
 #ifdef FEAT_EVAL
     dict_T	    *v_event;
diff --git a/src/mouse.c b/src/mouse.c
@@ -2234,7 +2234,7 @@ nv_mouse(cmdarg_T *cap)
 static int	held_button = MOUSE_RELEASE;
 
     void
-reset_held_button()
+reset_held_button(void)
 {
     held_button = MOUSE_RELEASE;
 }
diff --git a/src/normal.c b/src/normal.c
@@ -976,14 +976,14 @@ normal_cmd(
 
     // Reset finish_op, in case it was set
 #ifdef CURSOR_SHAPE
-    c = finish_op;
+    int prev_finish_op = finish_op;
 #endif
     finish_op = FALSE;
     may_trigger_modechanged();
 #ifdef CURSOR_SHAPE
     // Redraw the cursor with another shape, if we were in Operator-pending
     // mode or did a replace command.
-    if (c || ca.cmdchar == 'r')
+    if (prev_finish_op || ca.cmdchar == 'r')
     {
 	ui_cursor_shape();		// may show different cursor shape
 # ifdef FEAT_MOUSESHAPE
@@ -1110,14 +1110,14 @@ call_yank_do_autocmd(int regname)
  * from do_pending_operator().
  */
     void
-end_visual_mode()
+end_visual_mode(void)
 {
     end_visual_mode_keep_button();
     reset_held_button();
 }
 
     void
-end_visual_mode_keep_button()
+end_visual_mode_keep_button(void)
 {
 #ifdef FEAT_CLIPBOARD
     // If we are using the clipboard, then remember what was selected in case
@@ -3190,7 +3190,7 @@ nv_colon(cmdarg_T *cap)
     else if (cap->oap->op_type != OP_NOP
 	    && (cap->oap->start.lnum > curbuf->b_ml.ml_line_count
 		|| cap->oap->start.col >
-		(colnr_T)STRLEN(ml_get(cap->oap->start.lnum))
+				  (colnr_T)STRLEN(ml_get(cap->oap->start.lnum))
 		|| did_emsg
 	       ))
 	// The start of the operator has become invalid by the Ex command.
diff --git a/src/optionstr.c b/src/optionstr.c
@@ -3075,7 +3075,7 @@ check_ff_value(char_u *p)
  * restore_shm_value() exactly the same number of times.
  */
     void
-save_clear_shm_value()
+save_clear_shm_value(void)
 {
     if (STRLEN(p_shm) >= SHM_LEN)
     {
@@ -3094,7 +3094,7 @@ save_clear_shm_value()
  * Restore the shortmess Flags set from the save_clear_shm_value() function.
  */
     void
-restore_shm_value()
+restore_shm_value(void)
 {
     if (--set_shm_recursive == 0)
     {
diff --git a/src/popupmenu.c b/src/popupmenu.c
@@ -387,7 +387,7 @@ pum_display(
  * This will avoid clearing and redrawing the popup menu, prevent flicker.
  */
     void
-pum_call_update_screen()
+pum_call_update_screen(void)
 {
     call_update_screen = TRUE;
 
diff --git a/src/popupwin.c b/src/popupwin.c
@@ -3309,7 +3309,7 @@ f_popup_getoptions(typval_T *argvars, typval_T *rettv)
  * Return FALSE when the job has ended.
  */
     int
-error_if_term_popup_window()
+error_if_term_popup_window(void)
 {
     if (WIN_IS_POPUP(curwin) && curbuf->b_term != NULL
 					   && term_job_running(curbuf->b_term))
@@ -3543,7 +3543,7 @@ popup_no_mapping(void)
  * cursor moved far enough.
  */
     void
-popup_check_cursor_pos()
+popup_check_cursor_pos(void)
 {
     win_T *wp;
 
diff --git a/src/proto/filepath.pro b/src/proto/filepath.pro
@@ -1,11 +1,11 @@
 /* filepath.c */
 int modify_fname(char_u *src, int tilde_file, int *usedlen, char_u **fnamep, char_u **bufp, int *fnamelen);
 void shorten_dir(char_u *str);
+int file_is_readable(char_u *fname);
 void f_chdir(typval_T *argvars, typval_T *rettv);
 void f_delete(typval_T *argvars, typval_T *rettv);
 void f_executable(typval_T *argvars, typval_T *rettv);
 void f_exepath(typval_T *argvars, typval_T *rettv);
-int file_is_readable(char_u *fname);
 void f_filereadable(typval_T *argvars, typval_T *rettv);
 void f_filewritable(typval_T *argvars, typval_T *rettv);
 void f_finddir(typval_T *argvars, typval_T *rettv);
diff --git a/src/proto/gui_motif.pro b/src/proto/gui_motif.pro
@@ -32,8 +32,6 @@ void gui_mch_set_scrollbar_colors(scrollbar_T *sb);
 Window gui_x11_get_wid(void);
 char_u *gui_mch_browse(int saving, char_u *title, char_u *dflt, char_u *ext, char_u *initdir, char_u *filter);
 int gui_mch_dialog(int type, char_u *title, char_u *message, char_u *button_names, int dfltbutton, char_u *textfield, int ex_cmd);
-void gui_mch_enable_footer(int showit);
-void gui_mch_set_footer(char_u *s);
 void gui_mch_show_toolbar(int showit);
 int gui_mch_compute_toolbar_height(void);
 void motif_get_toolbar_colors(Pixel *bgp, Pixel *fgp, Pixel *bsp, Pixel *tsp, Pixel *hsp);
diff --git a/src/quickfix.c b/src/quickfix.c
@@ -8448,7 +8448,7 @@ ex_helpgrep(exarg_T *eap)
 
 # if defined(EXITFREE) || defined(PROTO)
     void
-free_quickfix()
+free_quickfix(void)
 {
     win_T	*win;
     tabpage_T	*tab;
diff --git a/src/register.c b/src/register.c
@@ -977,7 +977,7 @@ cmdline_paste_reg(
  * Shift the delete registers: "9 is cleared, "8 becomes "9, etc.
  */
     void
-shift_delete_registers()
+shift_delete_registers(void)
 {
     int		n;
 
@@ -2328,7 +2328,7 @@ get_register_name(int num)
  * Return the index of the register "" points to.
  */
     int
-get_unname_register()
+get_unname_register(void)
 {
     return y_previous == NULL ? -1 : y_previous - &y_regs[0];
 }
diff --git a/src/screen.c b/src/screen.c
@@ -379,7 +379,7 @@ char_needs_redraw(int off_from, int off_to, int cols)
  * Return the index in ScreenLines[] for the current screen line.
  */
     int
-screen_get_current_line_off()
+screen_get_current_line_off(void)
 {
     return (int)(current_ScreenLine - ScreenLines);
 }
@@ -3962,7 +3962,7 @@ screen_del_lines(
  * or inside a mapping.
  */
     int
-skip_showmode()
+skip_showmode(void)
 {
     // Call char_avail() only when we are going to show something, because it
     // takes a bit of time.  redrawing() may also call char_avail().
diff --git a/src/sound.c b/src/sound.c
@@ -339,7 +339,7 @@ sound_wndproc(HWND hwnd, UINT message, WPARAM wParam, LPARAM lParam)
 }
 
     static HWND
-sound_window()
+sound_window(void)
 {
     if (g_hWndSound == NULL)
     {
diff --git a/src/term.c b/src/term.c
diff --git a/src/terminal.c b/src/terminal.c
diff --git a/src/time.c b/src/time.c
diff --git a/src/userfunc.c b/src/userfunc.c
diff --git a/src/version.c b/src/version.c
diff --git a/src/vim.h b/src/vim.h
diff --git a/src/vim9compile.c b/src/vim9compile.c
diff --git a/src/window.c b/src/window.c

Original file line number	Diff line number	Diff line change
`@@ -4180,7 +4180,7 @@ channel_handle_events(int only_keep_open)`
`4180`	`4180`	`* Return TRUE when there is any channel with a keep_open flag.`
`4181`	`4181`	`*/`
`4182`	`4182`	`int`
`4183`		`-channel_any_keep_open()`
	`4183`	`+channel_any_keep_open(void)`
`4184`	`4184`	`{`
`4185`	`4185`	`channel_T *channel;`
`4186`	`4186`
Original file line number	Diff line number	Diff line change
`@@ -1764,7 +1764,7 @@ skipwhite_and_nl(char_u *q)`
`1764`	`1764`	`* columns (bytes) at the start of a given line`
`1765`	`1765`	`*/`
`1766`	`1766`	`int`
`1767`		`-getwhitecols_curline()`
	`1767`	`+getwhitecols_curline(void)`
`1768`	`1768`	`{`
`1769`	`1769`	`return getwhitecols(ml_get_curline());`
`1770`	`1770`	`}`
Original file line number	Diff line number	Diff line change
`@@ -257,7 +257,7 @@ start_global_changes(void)`
`257`	`257`	`* right text.`
`258`	`258`	`*/`
`259`	`259`	`static int`
`260`		`-is_clipboard_needs_update()`
	`260`	`+is_clipboard_needs_update(void)`
`261`	`261`	`{`
`262`	`262`	`return clipboard_needs_update;`
`263`	`263`	`}`
Original file line number	Diff line number	Diff line change
`@@ -734,7 +734,7 @@ ex_debuggreedy(exarg_T *eap)`
`734`	`734`	`}`
`735`	`735`
`736`	`736`	`static void`
`737`		`-update_has_expr_breakpoint()`
	`737`	`+update_has_expr_breakpoint(void)`
`738`	`738`	`{`
`739`	`739`	`int i;`
`740`	`740`
`@@ -751,7 +751,7 @@ update_has_expr_breakpoint()`
`751`	`751`	`* Return TRUE if there is any expression breakpoint.`
`752`	`752`	`*/`
`753`	`753`	`int`
`754`		`-debug_has_expr_breakpoint()`
	`754`	`+debug_has_expr_breakpoint(void)`
`755`	`755`	`{`
`756`	`756`	`return has_expr_breakpoint;`
`757`	`757`	`}`
Original file line number	Diff line number	Diff line change
`@@ -4607,7 +4607,7 @@ ins_end(int c)`
`4607`	`4607`	`}`
`4608`	`4608`
`4609`	`4609`	`static void`
`4610`		`-ins_s_left()`
	`4610`	`+ins_s_left(void)`
`4611`	`4611`	`{`
`4612`	`4612`	`int end_change = dont_sync_undo == FALSE; // end undoable change`
`4613`	`4613`	`#ifdef FEAT_FOLDING`
`@@ -4676,7 +4676,7 @@ ins_right(void)`
`4676`	`4676`	`}`
`4677`	`4677`
`4678`	`4678`	`static void`
`4679`		`-ins_s_right()`
	`4679`	`+ins_s_right(void)`
`4680`	`4680`	`{`
`4681`	`4681`	`int end_change = dont_sync_undo == FALSE; // end undoable change`
`4682`	`4682`	`#ifdef FEAT_FOLDING`
Original file line number	Diff line number	Diff line change
`@@ -1386,7 +1386,7 @@ do_cmdline(`
`1386`	`1386`	`* Handle when "did_throw" is set after executing commands.`
`1387`	`1387`	`*/`
`1388`	`1388`	`void`
`1389`		`-handle_did_throw()`
	`1389`	`+handle_did_throw(void)`
`1390`	`1390`	`{`
`1391`	`1391`	`char *p = NULL;`
`1392`	`1392`	`msglist_T *messages = NULL;`
Original file line number	Diff line number	Diff line change
`@@ -295,7 +295,7 @@ im_preedit_window_set_position(void)`
`295`	`295`	`}`
`296`	`296`
`297`	`297`	`static void`
`298`		`-im_preedit_window_open()`
	`298`	`+im_preedit_window_open(void)`
`299`	`299`	`{`
`300`	`300`	`char *preedit_string;`
`301`	`301`	`#if !GTK_CHECK_VERSION(3,16,0)`
`@@ -417,14 +417,14 @@ im_preedit_window_open()`
`417`	`417`	`}`
`418`	`418`
`419`	`419`	`static void`
`420`		`-im_preedit_window_close()`
	`420`	`+im_preedit_window_close(void)`
`421`	`421`	`{`
`422`	`422`	`if (preedit_window != NULL)`
`423`	`423`	`gtk_widget_hide(preedit_window);`
`424`	`424`	`}`
`425`	`425`
`426`	`426`	`static void`
`427`		`-im_show_preedit()`
	`427`	`+im_show_preedit(void)`
`428`	`428`	`{`
`429`	`429`	`im_preedit_window_open();`
`430`	`430`
Original file line number	Diff line number	Diff line change
`@@ -469,7 +469,7 @@ init_highlight(`
`469`	`469`	`* the user to override the color values. Only loaded once.`
`470`	`470`	`*/`
`471`	`471`	`static void`
`472`		`-load_default_colors_lists()`
	`472`	`+load_default_colors_lists(void)`
`473`	`473`	`{`
`474`	`474`	`// Lacking a default color list isn't the end of the world but it is likely`
`475`	`475`	`// an inconvenience so users should know when it is missing.`