patch 9.1.1601: Patch v8.1.0425 was wrong

h-east · zeertzjq · chrisbra · commit 6abe5e490470 · 2025-08-07T15:51:25.000+02:00
Problem:  Patch v8.1.0425 was wrong
Solution: Revert that patch (Hirohito Higashi)

This is because the root cause was fixed in 8.1.0786 and a regression
occurred elsewhere.

related: #3455
related: #3830
fixes: #11558
closes: #17899

Co-authored-by: zeertzjq &lt;zeertzjq@outlook.com&gt;
Signed-off-by: Hirohito Higashi &lt;h.east.727@gmail.com&gt;
Signed-off-by: Christian Brabandt &lt;cb@256bit.org&gt;
diff --git a/src/buffer.c b/src/buffer.c
@@ -2003,9 +2003,6 @@ enter_buffer(buf_T *buf)
     // mark cursor position as being invalid
     curwin->w_valid = 0;
 
-    buflist_setfpos(curbuf, curwin, curbuf->b_last_cursor.lnum,
-					      curbuf->b_last_cursor.col, TRUE);
-
     // Make sure the buffer is loaded.
     if (curbuf->b_ml.ml_mfp == NULL)	// need to load the file
     {
diff --git a/src/testdir/test_buffer.vim b/src/testdir/test_buffer.vim
@@ -613,4 +613,31 @@ func Test_closed_buffer_still_in_window()
   %bw!
 endfunc
 
+" Cursor position should be restored when switching to a buffer previously
+" viewed in a window, regardless of whether it's visible in another one.
+func Test_switch_to_previously_viewed_buffer()
+  set nostartofline
+  new Xviewbuf
+  call setline(1, range(1, 200))
+  let oldwin = win_getid()
+  vsplit
+
+  call cursor(100, 3)
+  edit Xotherbuf
+  buffer Xviewbuf
+  call assert_equal([0, 100, 3, 0], getpos('.'))
+
+  exe win_id2win(oldwin) .. 'close'
+  setlocal bufhidden=hide
+
+  call cursor(200, 3)
+  edit Xotherbuf
+  buffer Xviewbuf
+  call assert_equal([0, 200, 3, 0], getpos('.'))
+
+  bwipe! Xotherbuf
+  bwipe! Xviewbuf
+  set startofline&
+endfunc
+
 " vim: shiftwidth=2 sts=2 expandtab
diff --git a/src/version.c b/src/version.c
@@ -719,6 +719,8 @@ static char *(features[]) =
 
 static int included_patches[] =
 {   /* Add new patch number below this line */
+/**/
+    1601,
 /**/
     1600,
 /**/

Original file line number	Diff line number	Diff line change
`@@ -2003,9 +2003,6 @@ enter_buffer(buf_T *buf)`
`2003`	`2003`	`// mark cursor position as being invalid`
`2004`	`2004`	`curwin->w_valid = 0;`
`2005`	`2005`
`2006`		`- buflist_setfpos(curbuf, curwin, curbuf->b_last_cursor.lnum,`
`2007`		`- curbuf->b_last_cursor.col, TRUE);`
`2008`		`-`
`2009`	`2006`	`// Make sure the buffer is loaded.`
`2010`	`2007`	`if (curbuf->b_ml.ml_mfp == NULL) // need to load the file`
`2011`	`2008`	`{`