patch 8.2.1184: some tests fail

brammool · brammool · commit 2b6ef856fb89 · 2020-07-11T22:25:57.000+02:00
Problem:    Some tests fail.
Solution:   Adjust tests for different assert_fails() behavior.  Remove unused
            variable.
diff --git a/src/evalvars.c b/src/evalvars.c
@@ -3389,7 +3389,6 @@ static char_u	*redir_varname = NULL;
 var_redir_start(char_u *name, int append)
 {
     int		called_emsg_before;
-    int		err;
     typval_T	tv;
 
     // Catch a bad name early.
diff --git a/src/testdir/test_assert.vim b/src/testdir/test_assert.vim
@@ -208,12 +208,12 @@ func Test_notmatch()
 endfunc
 
 func Test_assert_fail_fails()
-  call assert_equal(1, assert_fails('xxx', {}))
-  call assert_match("Expected {} but got 'E731:", v:errors[0])
+  call assert_equal(1, assert_fails('xxx', 'E12345'))
+  call assert_match("Expected 'E12345' but got 'E492:", v:errors[0])
   call remove(v:errors, 0)
 
-  call assert_equal(1, assert_fails('xxx', {}, 'stupid'))
-  call assert_match("stupid: Expected {} but got 'E731:", v:errors[0])
+  call assert_equal(1, assert_fails('xxx', 'E9876', 'stupid'))
+  call assert_match("stupid: Expected 'E9876' but got 'E492:", v:errors[0])
   call remove(v:errors, 0)
 
   call assert_equal(1, assert_fails('echo', '', 'echo command'))
diff --git a/src/testdir/test_eval_stuff.vim b/src/testdir/test_eval_stuff.vim
@@ -1,5 +1,7 @@
 " Tests for various eval things.
 
+source view_util.vim
+
 function s:foo() abort
   try
     return [] == 0
@@ -17,13 +19,8 @@ func Test_nocatch_restore_silent_emsg()
     throw 1
   catch
   endtry
-  echoerr 'wrong'
-  let c1 = nr2char(screenchar(&lines, 1))
-  let c2 = nr2char(screenchar(&lines, 2))
-  let c3 = nr2char(screenchar(&lines, 3))
-  let c4 = nr2char(screenchar(&lines, 4))
-  let c5 = nr2char(screenchar(&lines, 5))
-  call assert_equal('wrong', c1 . c2 . c3 . c4 . c5)
+  echoerr 'wrong again'
+  call assert_equal('wrong again', ScreenLine(&lines))
 endfunc
 
 func Test_mkdir_p()
diff --git a/src/version.c b/src/version.c
@@ -754,6 +754,8 @@ static char *(features[]) =
 
 static int included_patches[] =
 {   /* Add new patch number below this line */
+/**/
+    1184,
 /**/
     1183,
 /**/

Original file line number	Diff line number	Diff line change
`@@ -3389,7 +3389,6 @@ static char_u *redir_varname = NULL;`
`3389`	`3389`	`var_redir_start(char_u *name, int append)`
`3390`	`3390`	`{`
`3391`	`3391`	`int called_emsg_before;`
`3392`		`- int err;`
`3393`	`3392`	`typval_T tv;`
`3394`	`3393`
`3395`	`3394`	`// Catch a bad name early.`