Skip to content

Commit 9f917b9

Browse files
committed
Check dict is not empty before acknowledging messages upon context exit. Closes googleapis#2878.
1 parent e26b437 commit 9f917b9

1 file changed

Lines changed: 2 additions & 1 deletion

File tree

pubsub/google/cloud/pubsub/subscription.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -509,4 +509,5 @@ def __enter__(self):
509509
return self
510510

511511
def __exit__(self, exc_type, exc_val, exc_tb):
512-
self._subscription.acknowledge(list(self), self._client)
512+
if self:
513+
self._subscription.acknowledge(list(self), self._client)

0 commit comments

Comments
 (0)