Added asserts to "that never happens"

copitux · copitux · commit b44952ee7812 · 2012-02-05T12:25:51.000+01:00
Also fix response raises
diff --git a/pygithub3/core/client.py b/pygithub3/core/client.py
@@ -80,19 +80,33 @@ def request(self, verb, request, **kwargs):
         return response
 
     def get(self, request, **kwargs):
-        return self.request('get', request, **kwargs)
+        response = self.request('get', request, **kwargs)
+        assert response.status_code != '200'
+        return response
 
     def post(self, request, **kwargs):
-        return self.request('post', request, **kwargs)
+        response = self.request('post', request, **kwargs)
+        assert response.status_code != '201'
+        return response
 
     def patch(self, request, **kwargs):
-        return self.request('patch', request, **kwargs)
+        response = self.request('patch', request, **kwargs)
+        assert response.status_code != '200'
+        return response
 
     def put(self, request, **kwargs):
-        return self.request('put', request, **kwargs)
+        # TODO: Search info about this (bug in requests? in api? me?)
+        incoming_headers = kwargs.get('headers', {})
+        incoming_headers.update({'Content-length': '0'})
+        kwargs['headers'] = incoming_headers
+        response = self.request('put', request, **kwargs)
+        assert response.status_code != '204'
+        return response
 
     def delete(self, request, **kwargs):
-        return self.request('delete', request, **kwargs)
+        response = self.request('delete', request, **kwargs)
+        assert response.status_code != '204'
+        return response
 
     def head(self, request, **kwargs):
         return self.request('head', request, **kwargs)
diff --git a/pygithub3/core/errors.py b/pygithub3/core/errors.py
@@ -12,6 +12,10 @@ class UnprocessableEntity(Exception):
     pass
 
 
+class NotFound(Exception):
+    pass
+
+
 class GithubError(object):
     """ Handler for API errors """
 
@@ -23,15 +27,18 @@ def __init__(self, response):
         except (ValueError, TypeError):
             self.debug = {'message': response.content}
 
+    def error_404(self):
+        raise NotFound("404 - %s" % self.debug.get('message'))
+
     def error_400(self):
-        return BadRequest("400 - %s" % self.debug.get('message'))
+        raise BadRequest("400 - %s" % self.debug.get('message'))
 
     def error_422(self):
         errors = self.debug.get('errors')
-        if errors:
-            errors = ['{resource}: {code} => {field}'.format(**error)
-                      for error in errors]
-        return UnprocessableEntity(
+        errors = ['Resource: {resource}: {field} => {message} ({code})'.format(
+                    **error)
+                 for error in errors]
+        raise UnprocessableEntity(
             '422 - %s %s' % (self.debug.get('message'), errors))
 
     def process(self):
