Fix math.log1p to pass some failed tests

Tetramad · Tetramad · commit c88c69a99305 · 2021-10-25T14:44:13.000+09:00
Now math.log1p with less than or equal to negative one should raise
ValueError with "math domain error" message
diff --git a/Lib/test/test_math.py b/Lib/test/test_math.py
@@ -1063,8 +1063,6 @@ def testLog(self):
         self.assertEqual(math.log(INF), INF)
         self.assertTrue(math.isnan(math.log(NAN)))
 
-    # TODO: RUSTPYTHON
-    @unittest.expectedFailure
     def testLog1p(self):
         self.assertRaises(TypeError, math.log1p)
         for n in [2, 2**90, 2**300]:
diff --git a/stdlib/src/math.rs b/stdlib/src/math.rs
@@ -145,8 +145,13 @@ mod math {
     }
 
     #[pyfunction]
-    fn log1p(x: ArgIntoFloat) -> f64 {
-        (x.to_f64() + 1.0).ln()
+    fn log1p(x: ArgIntoFloat, vm: &VirtualMachine) -> PyResult<f64> {
+        let x = x.to_f64();
+        if x.is_nan() || x > -1.0_f64 {
+            Ok((x + 1.0_f64).ln())
+        } else {
+            Err(vm.new_value_error("math domain error".to_owned()))
+        }
     }
 
     #[pyfunction]

Original file line number	Diff line number	Diff line change
`@@ -145,8 +145,13 @@ mod math {`
`145`	`145`	`}`
`146`	`146`
`147`	`147`	`#[pyfunction]`
`148`		`- fn log1p(x: ArgIntoFloat) -> f64 {`
`149`		`- (x.to_f64() + 1.0).ln()`
	`148`	`+ fn log1p(x: ArgIntoFloat, vm: &VirtualMachine) -> PyResult<f64> {`
	`149`	`+ let x = x.to_f64();`
	`150`	`+ if x.is_nan() \|\| x > -1.0_f64 {`
	`151`	`+ Ok((x + 1.0_f64).ln())`
	`152`	`+ } else {`
	`153`	`+ Err(vm.new_value_error("math domain error".to_owned()))`
	`154`	`+ }`
`150`	`155`	`}`
`151`	`156`
`152`	`157`	`#[pyfunction]`