Skip to content

Commit cf58ebe

Browse files
tokokotokoko
authored
chore: Remove all usage of RequestFeatureView (feast-dev#4039)
remove all usage of RequestFeatureViews Signed-off-by: tokoko <togurg14@freeuni.edu.ge>
1 parent e703b40 commit cf58ebe

23 files changed

+19
-696
lines changed

‎protos/feast/core/Registry.proto‎

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,6 @@ import "feast/core/FeatureTable.proto";
2727
import "feast/core/FeatureView.proto";
2828
import "feast/core/InfraObject.proto";
2929
import "feast/core/OnDemandFeatureView.proto";
30-
import "feast/core/RequestFeatureView.proto";
3130
import "feast/core/StreamFeatureView.proto";
3231
import "feast/core/DataSource.proto";
3332
import "feast/core/SavedDataset.proto";
@@ -41,7 +40,6 @@ message Registry {
4140
repeated FeatureView feature_views = 6;
4241
repeated DataSource data_sources = 12;
4342
repeated OnDemandFeatureView on_demand_feature_views = 8;
44-
repeated RequestFeatureView request_feature_views = 9;
4543
repeated StreamFeatureView stream_feature_views = 14;
4644
repeated FeatureService feature_services = 7;
4745
repeated SavedDataset saved_datasets = 11;

‎protos/feast/core/RequestFeatureView.proto‎

Lines changed: 0 additions & 51 deletions
This file was deleted.

‎protos/feast/registry/RegistryServer.proto‎

Lines changed: 0 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,6 @@ import "feast/core/Registry.proto";
77
import "feast/core/Entity.proto";
88
import "feast/core/DataSource.proto";
99
import "feast/core/FeatureView.proto";
10-
import "feast/core/RequestFeatureView.proto";
1110
import "feast/core/StreamFeatureView.proto";
1211
import "feast/core/OnDemandFeatureView.proto";
1312
import "feast/core/FeatureService.proto";
@@ -28,10 +27,6 @@ service RegistryServer{
2827
rpc GetFeatureView (GetFeatureViewRequest) returns (feast.core.FeatureView) {}
2928
rpc ListFeatureViews (ListFeatureViewsRequest) returns (ListFeatureViewsResponse) {}
3029

31-
// RequestFeatureView RPCs
32-
rpc GetRequestFeatureView (GetRequestFeatureViewRequest) returns (feast.core.RequestFeatureView) {}
33-
rpc ListRequestFeatureViews (ListRequestFeatureViewsRequest) returns (ListRequestFeatureViewsResponse) {}
34-
3530
// StreamFeatureView RPCs
3631
rpc GetStreamFeatureView (GetStreamFeatureViewRequest) returns (feast.core.StreamFeatureView) {}
3732
rpc ListStreamFeatureViews (ListStreamFeatureViewsRequest) returns (ListStreamFeatureViewsResponse) {}
@@ -126,23 +121,6 @@ message ListFeatureViewsResponse {
126121
repeated feast.core.FeatureView feature_views = 1;
127122
}
128123

129-
// RequestFeatureView
130-
131-
message GetRequestFeatureViewRequest {
132-
string name = 1;
133-
string project = 2;
134-
bool allow_cache = 3;
135-
}
136-
137-
message ListRequestFeatureViewsRequest {
138-
string project = 1;
139-
bool allow_cache = 2;
140-
}
141-
142-
message ListRequestFeatureViewsResponse {
143-
repeated feast.core.RequestFeatureView request_feature_views = 1;
144-
}
145-
146124
// StreamFeatureView
147125

148126
message GetStreamFeatureViewRequest {

‎sdk/python/docs/source/feast.protos.feast.core.rst‎

Lines changed: 0 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -228,22 +228,6 @@ feast.protos.feast.core.Registry\_pb2\_grpc module
228228
:undoc-members:
229229
:show-inheritance:
230230

231-
feast.protos.feast.core.RequestFeatureView\_pb2 module
232-
------------------------------------------------------
233-
234-
.. automodule:: feast.protos.feast.core.RequestFeatureView_pb2
235-
:members:
236-
:undoc-members:
237-
:show-inheritance:
238-
239-
feast.protos.feast.core.RequestFeatureView\_pb2\_grpc module
240-
------------------------------------------------------------
241-
242-
.. automodule:: feast.protos.feast.core.RequestFeatureView_pb2_grpc
243-
:members:
244-
:undoc-members:
245-
:show-inheritance:
246-
247231
feast.protos.feast.core.SavedDataset\_pb2 module
248232
------------------------------------------------
249233

‎sdk/python/docs/source/feast.rst‎

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -273,14 +273,6 @@ feast.repo\_upgrade module
273273
:undoc-members:
274274
:show-inheritance:
275275

276-
feast.request\_feature\_view module
277-
-----------------------------------
278-
279-
.. automodule:: feast.request_feature_view
280-
:members:
281-
:undoc-members:
282-
:show-inheritance:
283-
284276
feast.saved\_dataset module
285277
---------------------------
286278

‎sdk/python/feast/__init__.py‎

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,6 @@
2222
from .field import Field
2323
from .on_demand_feature_view import OnDemandFeatureView
2424
from .repo_config import RepoConfig
25-
from .request_feature_view import RequestFeatureView
2625
from .stream_feature_view import StreamFeatureView
2726
from .value_type import ValueType
2827

@@ -49,7 +48,6 @@
4948
"BigQuerySource",
5049
"FileSource",
5150
"RedshiftSource",
52-
"RequestFeatureView",
5351
"SnowflakeSource",
5452
"PushSource",
5553
"RequestSource",

‎sdk/python/feast/cli.py‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -381,7 +381,6 @@ def feature_view_list(ctx: click.Context):
381381
table = []
382382
for feature_view in [
383383
*store.list_feature_views(),
384-
*store.list_request_feature_views(),
385384
*store.list_on_demand_feature_views(),
386385
]:
387386
entities = set()

‎sdk/python/feast/diff/registry_diff.py‎

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -20,9 +20,6 @@
2020
OnDemandFeatureView as OnDemandFeatureViewProto,
2121
)
2222
from feast.protos.feast.core.OnDemandFeatureView_pb2 import OnDemandFeatureViewSpec
23-
from feast.protos.feast.core.RequestFeatureView_pb2 import (
24-
RequestFeatureView as RequestFeatureViewProto,
25-
)
2623
from feast.protos.feast.core.StreamFeatureView_pb2 import (
2724
StreamFeatureView as StreamFeatureViewProto,
2825
)
@@ -110,7 +107,6 @@ def tag_objects_for_keep_delete_update_add(
110107
FeatureViewProto,
111108
FeatureServiceProto,
112109
OnDemandFeatureViewProto,
113-
RequestFeatureViewProto,
114110
StreamFeatureViewProto,
115111
ValidationReferenceProto,
116112
)
@@ -339,7 +335,6 @@ def apply_diff_to_registry(
339335
elif feast_object_diff.feast_object_type in [
340336
FeastObjectType.FEATURE_VIEW,
341337
FeastObjectType.ON_DEMAND_FEATURE_VIEW,
342-
FeastObjectType.REQUEST_FEATURE_VIEW,
343338
FeastObjectType.STREAM_FEATURE_VIEW,
344339
]:
345340
feature_view_obj = cast(
@@ -383,7 +378,6 @@ def apply_diff_to_registry(
383378
elif feast_object_diff.feast_object_type in [
384379
FeastObjectType.FEATURE_VIEW,
385380
FeastObjectType.ON_DEMAND_FEATURE_VIEW,
386-
FeastObjectType.REQUEST_FEATURE_VIEW,
387381
FeastObjectType.STREAM_FEATURE_VIEW,
388382
]:
389383
registry.apply_feature_view(

‎sdk/python/feast/feast_object.py‎

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -11,20 +11,17 @@
1111
from .protos.feast.core.FeatureService_pb2 import FeatureServiceSpec
1212
from .protos.feast.core.FeatureView_pb2 import FeatureViewSpec
1313
from .protos.feast.core.OnDemandFeatureView_pb2 import OnDemandFeatureViewSpec
14-
from .protos.feast.core.RequestFeatureView_pb2 import RequestFeatureViewSpec
1514
from .protos.feast.core.StreamFeatureView_pb2 import StreamFeatureViewSpec
1615
from .protos.feast.core.ValidationProfile_pb2 import (
1716
ValidationReference as ValidationReferenceProto,
1817
)
19-
from .request_feature_view import RequestFeatureView
2018
from .saved_dataset import ValidationReference
2119
from .stream_feature_view import StreamFeatureView
2220

2321
# Convenience type representing all Feast objects
2422
FeastObject = Union[
2523
FeatureView,
2624
OnDemandFeatureView,
27-
RequestFeatureView,
2825
BatchFeatureView,
2926
StreamFeatureView,
3027
Entity,
@@ -36,7 +33,6 @@
3633
FeastObjectSpecProto = Union[
3734
FeatureViewSpec,
3835
OnDemandFeatureViewSpec,
39-
RequestFeatureViewSpec,
4036
StreamFeatureViewSpec,
4137
EntitySpecV2,
4238
FeatureServiceSpec,

0 commit comments

Comments
 (0)