Skip to content

Commit c1579c7

Browse files
fix: Make sure schema is used when calling get_table_query_string method for Snowflake datasource (feast-dev#4131)
* Fix get_table_query_string method for Snowflake datasource Signed-off-by: TomSteenbergen <tomsteenbergen1995@gmail.com> * Add quotes to table string Signed-off-by: TomSteenbergen <tomsteenbergen1995@gmail.com> --------- Signed-off-by: TomSteenbergen <tomsteenbergen1995@gmail.com>
1 parent 95acfb4 commit c1579c7

1 file changed

Lines changed: 3 additions & 1 deletion

File tree

sdk/python/feast/infra/offline_stores/snowflake_source.py

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -191,8 +191,10 @@ def validate(self, config: RepoConfig):
191191

192192
def get_table_query_string(self) -> str:
193193
"""Returns a string that can directly be used to reference this table in SQL."""
194-
if self.database and self.table:
194+
if self.database and self.schema and self.table:
195195
return f'"{self.database}"."{self.schema}"."{self.table}"'
196+
elif self.schema and self.table:
197+
return f'"{self.schema}"."{self.table}"'
196198
elif self.table:
197199
return f'"{self.table}"'
198200
else:

0 commit comments

Comments
 (0)