Skip to content

Commit 412d625

Browse files
felixwang9817felixwang9817
authored
feat: Add owner field to Entity and rename labels to tags
* Add owner field to Entity and rename labels to tags Signed-off-by: Felix Wang <wangfelix98@gmail.com> * Change all entities in tests to reference tags instead of labels Signed-off-by: Felix Wang <wangfelix98@gmail.com> * Add deprecation warning for labels argument Signed-off-by: Felix Wang <wangfelix98@gmail.com>
1 parent 0af8adb commit 412d625

File tree

7 files changed

+143
-223
lines changed

7 files changed

+143
-223
lines changed

‎java/serving/src/test/java/feast/serving/util/DataGenerator.java‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -116,12 +116,12 @@ public static EntityProto.EntitySpecV2 createEntitySpecV2(
116116
String name,
117117
String description,
118118
ValueProto.ValueType.Enum valueType,
119-
Map<String, String> labels) {
119+
Map<String, String> tags) {
120120
return EntityProto.EntitySpecV2.newBuilder()
121121
.setName(name)
122122
.setDescription(description)
123123
.setValueType(valueType)
124-
.putAllLabels(labels)
124+
.putAllTags(tags)
125125
.build();
126126
}
127127

‎protos/feast/core/Entity.proto‎

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,10 @@ message EntitySpecV2 {
4848
string join_key = 4;
4949

5050
// User defined metadata
51-
map<string,string> labels = 8;
51+
map<string,string> tags = 8;
52+
53+
// Owner of the entity.
54+
string owner = 10;
5255
}
5356

5457
message EntityMeta {

0 commit comments

Comments
 (0)