Skip to content

Commit 25b796f

Browse files
terryyylimterryyylim
authored
Refactor Python SDK to remove v1 concepts (feast-dev#1023)
* Cleanup cli Signed-off-by: Terence <terencelimxp@gmail.com> * Cleanup Python SDK Signed-off-by: Terence <terencelimxp@gmail.com> * Cleanup python unit tests Signed-off-by: Terence <terencelimxp@gmail.com> * Refactor and parallelize e2e redis tests Signed-off-by: Terence <terencelimxp@gmail.com> * Remove e2e bq tests Signed-off-by: Terence <terencelimxp@gmail.com> * Fix env variable Signed-off-by: Terence <terencelimxp@gmail.com> * Fix pytest redis Signed-off-by: Terence <terencelimxp@gmail.com> * Revert "Remove e2e bq tests" This reverts commit fa0bcab17b244142dbdc44f6c48a4108e5a2b522. Signed-off-by: Terence <terencelimxp@gmail.com> * Fix pytest redis Signed-off-by: Terence <terencelimxp@gmail.com> * Remove unused batch tests Signed-off-by: Terence <terencelimxp@gmail.com> * Fix docker-compose test Signed-off-by: Terence <terencelimxp@gmail.com> * Address PR comments Signed-off-by: Terence <terencelimxp@gmail.com> * Remove src folder for e2e tests Signed-off-by: Terence <terencelimxp@gmail.com> * Address PR comments Signed-off-by: Terence <terencelimxp@gmail.com> * Expose Source instead of Options native class Signed-off-by: Terence <terencelimxp@gmail.com> * Refactor e2e tests without specification Signed-off-by: Terence <terencelimxp@gmail.com> * Fix data partitioning for ingest method Signed-off-by: Terence <terencelimxp@gmail.com> * Cleanup date partition logic and add ingest test Signed-off-by: Terence <terencelimxp@gmail.com> * Remove type field from datasource classes Signed-off-by: Terence <terencelimxp@gmail.com> * Remove not so useful test Signed-off-by: Terence <terencelimxp@gmail.com> * Address PR comments Signed-off-by: Terence <terencelimxp@gmail.com> * Cleanup the way protos are converted Signed-off-by: Terence <terencelimxp@gmail.com> * Split ingest function and add more tests Signed-off-by: Terence <terencelimxp@gmail.com> * Cleanup FeatureTable and DataSource Signed-off-by: Terence <terencelimxp@gmail.com> * Some fixes Signed-off-by: Terence <terencelimxp@gmail.com> * Add BQ source test Signed-off-by: Terence <terencelimxp@gmail.com> * Revert "Add BQ source test" This reverts commit d567937eaf80190cde59128c19af4644c810e7d9. Signed-off-by: Terence <terencelimxp@gmail.com> * Add BQ source test Signed-off-by: Terence <terencelimxp@gmail.com> * Update perms for bq test Signed-off-by: Terence <terencelimxp@gmail.com> * Revert "Update perms for bq test" This reverts commit 7e74e9069f97af9c0e108aba8f4bd1197ba5c3ed. Signed-off-by: Terence <terencelimxp@gmail.com> * Cleanup datasource Signed-off-by: Terence <terencelimxp@gmail.com> * Renaming and optimize file search loop Signed-off-by: Terence <terencelimxp@gmail.com> * Remove duplicated code in pytest Signed-off-by: Terence <terencelimxp@gmail.com> * Fix prow config Signed-off-by: Terence <terencelimxp@gmail.com>
1 parent eb865ea commit 25b796f

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

48 files changed

+1496
-7824
lines changed

‎Makefile‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -86,7 +86,7 @@ lint-python:
8686
cd ${ROOT_DIR}/sdk/python; flake8 feast/ tests/
8787
cd ${ROOT_DIR}/sdk/python; black --check feast tests
8888

89-
cd ${ROOT_DIR}/tests/e2e; mypy redis/
89+
cd ${ROOT_DIR}/tests/e2e; mypy .
9090
cd ${ROOT_DIR}/tests/e2e; isort . --check-only
9191
cd ${ROOT_DIR}/tests/e2e; flake8 .
9292
cd ${ROOT_DIR}/tests/e2e; black --check .

‎infra/scripts/test-docker-compose.sh‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -63,4 +63,4 @@ export FEAST_ONLINE_SERVING_CONTAINER_IP_ADDRESS=$(docker inspect -f '{{range .N
6363
${PROJECT_ROOT_DIR}/infra/scripts/wait-for-it.sh ${FEAST_ONLINE_SERVING_CONTAINER_IP_ADDRESS}:6566 --timeout=120
6464

6565
# Run e2e tests for Redis
66-
docker exec feast_jupyter_1 bash -c 'cd /feast/tests/e2e/redis && pytest --verbose -rs basic-ingest-redis-serving.py --core_url core:6565 --serving_url=online_serving:6566 --jobcontroller_url=jobcontroller:6570 --kafka_brokers=kafka:9092'
66+
docker exec feast_jupyter_1 bash -c 'cd /feast/tests/e2e && pytest *.py --core_url core:6565 --serving_url=online_serving:6566 --kafka_brokers=kafka:9092'

‎infra/scripts/test-end-to-end-batch-dataflow.sh‎

Lines changed: 0 additions & 307 deletions
This file was deleted.

0 commit comments

Comments
 (0)