-
Notifications
You must be signed in to change notification settings - Fork 1
Expand file tree
/
Copy pathISSUES
More file actions
224 lines (185 loc) · 7.85 KB
/
Copy pathISSUES
File metadata and controls
224 lines (185 loc) · 7.85 KB
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
********************** Unsolved issues **********************
1. When tree node reaches the MAX_TREE_LEVEL but the particles exceeding MAX_PACKAGE_SIZE, may be not stable.
2. While PM thread runs asyncronizing with Tree threads, sometimes there would occur memory collision, don't know why.
3. After long time simulation, while z is rather small, the particle was clustered, and the computation is not balanced. Work has been down for inner process calculating.
******************** Code fixing history ********************
------------------2015/04/17 14:00--------------------
traversal.h
traversal.c
A full-level expansion scheme for enqueuing during tree traversal.
A mature load balance scheme in local calculation.
ppkernel.h
nbody.256
Parameter adjusting for better performance in current cases.
------------------2015/04/09 17:00--------------------
traversal.h
traversal.c
A two-level expansion for enqueuing during tree traversal.
------------------2015/03/30 10:00--------------------
traversal.h
traversal.c
Modified the task pool with a indirect refering array.
------------------2015/03/28 19:00--------------------
traversal.h
traversal.c
Added checknan/checkpart/checkaccpm functions for debugging.
Eliminated a bug in queue processing.
partmesh.c
Added some codes (commented) for debugging.
main.c
Corrected the barrier issue and the output information.
------------------2015/03/08 17:00--------------------
stepping.c
Using kick1_pm and kick2_pm function instead of the old kick_system function.
initial.c
Corrected the initialization of EPS2.
Changed the random velocity initialization contidion.
main.c
Added the refine step running mode.
------------------2015/02/26 7:00--------------------
ppkernel.c
Rewrite the calculation with macro definitions.
------------------2015/02/08 7:00--------------------
ppkernel.c
Corrected two numeric mistake in ppkernel.
traversal.c
Fixed the addition of acceleration with NMK_PP_TAB defined, do not need to multiply the GRAVITY const.
------------------2015/01/30 0:00--------------------
inital.c
traversal.c
pp9m.c
ppverify.c
nbody.ver
Adding the verifying function in the code. To enable it, set PP_VERIFY macro enabled. To Generate correct PP result file, set PP_GEN_VER_FILE enabled.
The verifying system should be a box with 200000, particles distributed uniformly in [87501-112499].
Usage of ppverify.c : ./ppverify [nPart/1048576 [file to be check/pp.acc [file as standard/ppn.acc [index file/pp.ori [gravity const/1.0]]]]]
ppkernel.c
traversal.c
Fixed the two issues for mass pp calculation.
Fixed the error of setting wrong start and ending block for each thread.
Fixed the search algorithm while TA is leaf buf TB is not.
domain.c
Fixed the mesh masking issue (upper lwer) for the case with large empty space.
Modifid some judge condition to correct the adjoining particle processing error for 'dcount' calculation and unneccesary received partiles.
------------------2015/01/21 22:00--------------------
proto.h
global.h
inital.c
traversal.h
ppkernel.h
ppkernel.c
Add the prefactor in PP calculation. G(erfc(r/2rs) + (r/(sqrt(pi)*rs)*exp(-r^2/2s^2))) * oldfactor.
Modified the EPS2 into constants structure, and PP use the *constants as an parameter.
Add NMK_NAIVE_GRAVITY for naive gravity calculation.
main.c
partmesh.c
Setting FFTW2_LIB as default, since MKL doesn't support FFTW3 MPI interface.
------------------2015/01/13 13:00--------------------
traversal.c
Modified some judge critierian in DTT tree walking on MIC to raise the performance.
traversal.c
initial.h
initial.c
global.c
Add the INPUT VARIBLES and functions for CPU-MIC load balancing.
DYNAMIC_LOAD/DYNLOAD: if non zero, enable the load balancing.
------------------2015/01/13 1:00--------------------
traversal.c
Modified DTT process logic, if A and B are equal in size, seperate A first (B in old versions). If A is leaf, using a DST for B tree entirely, avoid more queue operations. If B's childrens are leaf nodes, also add it to A's pp, instead of enqueue operations.
------------------2015/01/12 14:00--------------------
global.h
initial.h
initial.c
Made the chages for this INPUT VARIBLES:
(varible name/input string: usage notes.)
NTHREAD_CPU/NTHCPU: CPU thread numbers per MPI PROCESS while tree walking.
NTHREAD_MIC/NTHMIC: MIC thread numbers per MIC CARD.
NTHREAD_TREE/NTHTREE: CPU thread numbers per MPI PROCESS for tree building (coz of sometimes too many threads will get an segmentation fault in tree building).
NP_PER_NODE/NPNODE: the number of how many MPI PROCESSes in one node.
NMIC_PER_NODE/MICNUM: the number of MICs in one node.
NTEAM_CPU/NTEAMCPU: master thread numbers for task pools on CPU in single MPI PROCESS.
NTEAM_MIC/NTEAMMIC: master thread numbers for task pools on MIC in single MPI PROCESS.
CPU_RATIO/CPURATIO: the ratio to indicate how much calculation should be done on CPU in tree walking.
RND_PART/RNDPART: if not 0, random uniform distributed particles should be generated instead of file reading.
MAX_TREE_LEVEL/TREEMAX: the maximum level of a local tree.
MIN_TREE_LEVEL/TREEMIN: the minimum level of a local tree.
MAX_PACKAGE_SIZE/NCRITI: the normal Ncritical in tree building.
MIC_PP_THRESHOLD/PPSIZE: the Ncritical used on MIC while tree walking.
Added init_random_particles() function.
Added a section to check the particles not equal to BOX_SIZE due to precision issue.
dbginfo.h
Added extern definition of 'stdio' functions and varibles for correctly offload on MIC.
domain.h
domain.c
Added nnode varibles to remember the number of tree nodes malloced for offloading to MIC.
global.h
global.c
Modified the MPI_Abort() to exit() for offload compilation in system_exit() since MPI_Abort() could not be offloaded.
Added xmemalign() function for aligned memory allocation.
proto.h
Added CalcBode and TransBody structure for force calculation and transfering.
Added rmax to Node stucture to use in acceptance judging.
main.c <-- driver.c
Added timer sections, warmup to MIC function, and tree building and walking functions..
subtree.h
subtree.c
queue.h
queue.c
traversal.h
traversal.c
Tree building and force calculation functions. Cleared from old version, using new data structures.
pp.c
ppm.c
ppkernel.h
ppkernel.c
Makefile
Moved from old version, with minor modification.
------------------2015/01/05 22:00--------------------
initial.c
Correct the char array length of 'name' and 'value'.
stepping.c
Included 'math.h'.
Strictly modified draft() function to adjust border particles correction about its precision.
------------------2015/01/05 12:00--------------------
nmk_utils.h:
New file for utility functions. Now including dbginfo macros and dtime() function.
dbginfo.h:
Macros for log and debug info output.
dtime.h:
dtime() implementation.
offload.h:
Offload macros defination.
global.h:
global.c:
Moving dtime() to dtime.h.
Added xrealloc() function.
partition.c:
MESH_BITS and PEANO bits need to be equal now, one mesh could not be seperated in two MPI processes. Then 'upper' mesh should be exclude in current domain.
domain.h:
domain.c:
Added rank, nproc vars in Domain structure.
Added *tree, *mroot, *pidx to indicate the local tree nodes, root of each mesh, first particle index of each meshes.
Modified the domain creation and deletion process.
Deleted *cuboid.
The mesh 'upper' should be not include in local domain since no mesh should be splited (peano_bits==mesh_bits).
Corrected the bug in adjoint counting. see 'if (x<0 || x>=In) continue;' etc.
Combine the particle data with adjointed particles.
Strictly modified the adjointed particle processing functions in broadcast_frontiers.
------------------2015/01/01 00:00--------------------
proto.h
global.h
global.c
initial.h
initial.c
partition.h
partition.c
partmesh.h
partmesh.c
driver.h
driver.c
iosnap.h
iosnap.c
stepping.h
stepping.c
Based on the new PM code with new structure.
------------------------------------------------------