codeformat: Run sed only on requested files

jepler · jepler · commit 0403a2cca59e · 2021-03-15T18:10:43.000-05:00
When running from pre-commit, we believe the different invocations of
sed were racing with each other, sometimes leaving zero-byte files in
the filesystem (ow)
diff --git a/tools/codeformat.py b/tools/codeformat.py
@@ -167,10 +167,7 @@ def batch(cmd, files, N=200):
         for file in lang_files(C_EXTS):
             fixup_c(file)
         # Revert "// |" back to "//|"
-        subprocess.call(
-            "find shared-bindings ports/*/bindings -name '*.c' -exec sed -i 's/\/ |/\/|/' {} \;",
-            shell=True,
-        )
+        batch(["sed", "-i", "s,^// |,//|,"], lang_files(C_EXTS))
 
     # Format Python files with black.
     if format_py:
