Skip to content

Commit 02a9220

Browse files
author
Chan Chak Shing
committed
Fix extension popup shows rulesets from previous pages
1 parent d9d75f2 commit 02a9220

1 file changed

Lines changed: 10 additions & 6 deletions

File tree

‎chromium/background-scripts/background.js‎

Lines changed: 10 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -320,6 +320,14 @@ function onBeforeRequest(details) {
320320
return;
321321
}
322322

323+
// Clear the content shown in the extension popup.
324+
// This needed to be done before this listener returns,
325+
// otherwise, the extension page might include rulesets
326+
// from previous page.
327+
if (details.type == "main_frame") {
328+
appliedRulesets.removeTab(details.tabId);
329+
}
330+
323331
let uri = new URL(details.url);
324332

325333
/**
@@ -387,12 +395,6 @@ function onBeforeRequest(details) {
387395
return redirectOnCancel(shouldCancel, details.url);
388396
}
389397

390-
if (details.type == "main_frame") {
391-
appliedRulesets.removeTab(details.tabId);
392-
}
393-
394-
let potentiallyApplicable = all_rules.potentiallyApplicableRulesets(uri.hostname);
395-
396398
if (redirectCounter.get(details.requestId) >= 8) {
397399
util.log(util.NOTE, "Redirect counter hit for " + uri.href);
398400
urlBlacklist.add(uri.href);
@@ -405,6 +407,8 @@ function onBeforeRequest(details) {
405407
let upgradeToSecure = false;
406408
let newuristr = null;
407409

410+
let potentiallyApplicable = all_rules.potentiallyApplicableRulesets(uri.hostname);
411+
408412
for (let ruleset of potentiallyApplicable) {
409413
if (details.url.match(ruleset.scope)) {
410414
appliedRulesets.addRulesetToTab(details.tabId, details.type, ruleset);

0 commit comments

Comments
 (0)