Skip to content

Commit b385cb4

Browse files
author
Jayapal
committed
Fixed test case failures in network acl
1 parent 36cbc2d commit b385cb4

2 files changed

Lines changed: 19 additions & 17 deletions

File tree

server/test/com/cloud/vpc/NetworkACLManagerTest.java

Lines changed: 9 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,7 @@
2222

2323
import javax.inject.Inject;
2424

25+
import com.cloud.network.vpc.*;
2526
import junit.framework.TestCase;
2627

2728
import org.apache.log4j.Logger;
@@ -52,13 +53,6 @@
5253
import com.cloud.network.dao.NetworkDao;
5354
import com.cloud.network.dao.NetworkVO;
5455
import com.cloud.network.element.NetworkACLServiceProvider;
55-
import com.cloud.network.vpc.NetworkACLItem;
56-
import com.cloud.network.vpc.NetworkACLItemDao;
57-
import com.cloud.network.vpc.NetworkACLItemVO;
58-
import com.cloud.network.vpc.NetworkACLManager;
59-
import com.cloud.network.vpc.NetworkACLManagerImpl;
60-
import com.cloud.network.vpc.NetworkACLVO;
61-
import com.cloud.network.vpc.VpcManager;
6256
import com.cloud.network.vpc.dao.NetworkACLDao;
6357
import com.cloud.network.vpc.dao.VpcGatewayDao;
6458
import com.cloud.tags.dao.ResourceTagDao;
@@ -94,6 +88,8 @@ public class NetworkACLManagerTest extends TestCase {
9488
NetworkModel _networkModel;
9589
@Inject
9690
List<NetworkACLServiceProvider> _networkAclElements;
91+
@Inject
92+
VpcService _vpcSrv;
9793

9894
private NetworkACLVO acl;
9995
private NetworkACLItemVO aclItem;
@@ -220,6 +216,12 @@ public VpcGatewayDao vpcGatewayDao() {
220216
return Mockito.mock(VpcGatewayDao.class);
221217
}
222218

219+
@Bean
220+
public VpcService vpcService() {
221+
return Mockito.mock(VpcService.class);
222+
}
223+
224+
223225
public static class Library implements TypeFilter {
224226
@Override
225227
public boolean match(MetadataReader mdr, MetadataReaderFactory arg1) throws IOException {

server/test/com/cloud/vpc/NetworkACLServiceTest.java

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,7 @@
2020

2121
import javax.inject.Inject;
2222

23+
import com.cloud.network.vpc.*;
2324
import com.cloud.network.vpc.dao.VpcDao;
2425
import junit.framework.TestCase;
2526

@@ -49,16 +50,6 @@
4950
import com.cloud.exception.InvalidParameterValueException;
5051
import com.cloud.network.NetworkModel;
5152
import com.cloud.network.dao.NetworkDao;
52-
import com.cloud.network.vpc.NetworkACLItem;
53-
import com.cloud.network.vpc.NetworkACLItemDao;
54-
import com.cloud.network.vpc.NetworkACLItemVO;
55-
import com.cloud.network.vpc.NetworkACLManager;
56-
import com.cloud.network.vpc.NetworkACLService;
57-
import com.cloud.network.vpc.NetworkACLServiceImpl;
58-
import com.cloud.network.vpc.NetworkACLVO;
59-
import com.cloud.network.vpc.Vpc;
60-
import com.cloud.network.vpc.VpcManager;
61-
import com.cloud.network.vpc.VpcVO;
6253
import com.cloud.network.vpc.dao.NetworkACLDao;
6354
import com.cloud.network.vpc.dao.VpcGatewayDao;
6455
import com.cloud.tags.dao.ResourceTagDao;
@@ -89,6 +80,9 @@ public class NetworkACLServiceTest extends TestCase {
8980
EntityManager _entityMgr;
9081
@Inject
9182
VpcDao _vpcDao;
83+
@Inject
84+
VpcService _vpcSrv;
85+
9286

9387
private CreateNetworkACLCmd createACLItemCmd;
9488
private NetworkACLVO acl;
@@ -254,6 +248,12 @@ public VpcDao vpcDao () {
254248
return Mockito.mock(VpcDao.class);
255249
}
256250

251+
@Bean
252+
public VpcService vpcService() {
253+
return Mockito.mock(VpcService.class);
254+
}
255+
256+
257257
public static class Library implements TypeFilter {
258258
@Override
259259
public boolean match(MetadataReader mdr, MetadataReaderFactory arg1) throws IOException {

0 commit comments

Comments
 (0)