SAMLUtils: Fix NPE incase signature is generated with a null privateKey

yadvr · yadvr · commit 5a0ed8764be1 · 2014-09-12T15:46:44.000+02:00
Signed-off-by: Rohit Yadav &lt;rohit.yadav@shapeblue.com&gt;
diff --git a/utils/src/org/apache/cloudstack/utils/auth/SAMLUtils.java b/utils/src/org/apache/cloudstack/utils/auth/SAMLUtils.java
@@ -218,6 +218,9 @@ public static Response decodeSAMLResponse(String responseMessage)
 
     public static String generateSAMLRequestSignature(String urlEncodedString, PrivateKey signingKey)
             throws NoSuchAlgorithmException, SignatureException, InvalidKeyException, UnsupportedEncodingException {
+        if (signingKey == null || urlEncodedString == null) {
+            return null;
+        }
         String url = urlEncodedString + "&SigAlg=" + URLEncoder.encode(SignatureConstants.ALGO_ID_SIGNATURE_RSA_SHA1, HttpUtils.UTF_8);
         Signature signature = Signature.getInstance("SHA1withRSA");
         signature.initSign(signingKey);
