Please use the following template to submit a pull request, filling in at least the "Text for release notes" and/or "Further details". Thank You!
If this pull request should be mentioned in the release notes,
please provide a short description matching the style of the GAP
CHANGES.md file in the root directory.
If necessary, please provide further details here.
- proper formatting
If your code contains kernel C code, run clang-format on it; the
simplest way is to use git clang-format, e.g. like this (don't
forget to commit the resulting changes):
git clang-format $(git merge-base HEAD master)
-
usage of relevant labels
- either
release notes: not neededorrelease notes: to be added - at least one of the labels
bugorenhancementornew feature - for changes meant to be backported to
stable-4.Xadd thebackport-to-4.Xlabel - consider adding any of the labels
build system,documentation,kernel,library,tests
- either
-
runnable tests
-
lines changed in commits are sufficiently covered by the tests
-
adequate pull request title
-
well formulated text for release notes
-
relevant documentation updates
-
sensible comments in the code