Skip to content

Commit db8ee9e

Browse files
committed
Fix rewriter.js, which went out of date.
Also update it to always rewrite to HTTPS, rather than protocol-relative.
1 parent f00e631 commit db8ee9e

File tree

1 file changed

+3
-10
lines changed

1 file changed

+3
-10
lines changed

rewriter/rewriter.js

Lines changed: 3 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,6 @@ var path = require("path"),
2020
readdirp = require('readdirp'),
2121
es = require('event-stream'),
2222

23-
lrucache = require("../chromium/lru"),
2423
rules = require("../chromium/rules"),
2524

2625
URI = require("URIjs");
@@ -72,20 +71,14 @@ URI.find_uri_expression = /\b((?:http:(?:\/{1,3}|[a-z0-9%])|www\d{0,3}[.]|[a-z0-
7271
function processFile(filename) {
7372
var contents = fs.readFileSync(filename, 'utf8');
7473
var rewrittenFile = URI.withinString(contents, function(url) {
74+
console.log("Found ", url);
7575
var uri = new URI(url);
7676
if (uri.protocol() != 'http') return url;
7777

7878
uri.normalize();
7979
var rewritten = ruleSets.rewriteURI(uri.toString(), uri.host());
8080
if (rewritten) {
81-
// If the rewrite was just a protocol change, output protocol-relative
82-
// URIs.
83-
var rewrittenUri = new URI(rewritten).protocol('http');
84-
if (rewrittenUri.toString() === uri.toString()) {
85-
return rewrittenUri.protocol('').toString();
86-
} else {
87-
return rewritten;
88-
}
81+
return rewritten;
8982
} else {
9083
return url;
9184
}
@@ -103,7 +96,7 @@ function loadRuleSets() {
10396
console.log("Loading rules...");
10497
var fileContents = fs.readFileSync(path.join(__dirname, '../pkg/crx/rules/default.rulesets'), 'utf8');
10598
var xml = new DOMParser().parseFromString(fileContents, 'text/xml');
106-
ruleSets = new rules.RuleSets("fake user agent", lrucache.LRUCache, {});
99+
ruleSets = new rules.RuleSets({});
107100
ruleSets.addFromXml(xml);
108101
}
109102

0 commit comments

Comments
 (0)