Skip to content

Commit bc9ef14

Browse files
committed
Only skip ruleset with securecookie if we're changing list of targets
1 parent c6bbda2 commit bc9ef14

1 file changed

Lines changed: 6 additions & 6 deletions

File tree

‎utils/trivialize-rules/trivialize-rules.js‎

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -98,10 +98,6 @@ files.fork().zipAll([ sources.fork(), rules ]).map(([name, source, ruleset]) =>
9898
const info = createTag('INFO', chalk.green, console.info);
9999
const fail = createTag('FAIL', chalk.red, console.error);
100100

101-
if (ruleset.securecookie) {
102-
return;
103-
}
104-
105101
let targets = ruleset.target.map(target => target.$.host);
106102
let rules = ruleset.rule.map(rule => rule.$);
107103

@@ -183,16 +179,20 @@ files.fork().zipAll([ sources.fork(), rules ]).map(([name, source, ruleset]) =>
183179

184180
if (!rules.every(isStatic)) return;
185181

186-
info`trivialized`;
187-
188182
domains = Array.from(domains);
189183

190184
if (domains.slice().sort().join('\n') !== targets.sort().join('\n')) {
185+
if (ruleset.securecookie) {
186+
return;
187+
}
188+
191189
source = replaceXML(source, 'target', domains.map(domain => `<target host="${domain}" />`));
192190
}
193191

194192
source = replaceXML(source, 'rule', ['<rule from="^http:" to="https:" />']);
195193

194+
info`trivialized`;
195+
196196
return writeFile(`${rulesDir}/${name}`, source);
197197

198198
})

0 commit comments

Comments
 (0)