Skip to content

Commit 0fb76e9

Browse files
EXPEbdodlaBhargav Dodla
EXPEbdodla
and
Bhargav Dodla
authored
fix: Removed protobuf as a required dependency (feast-dev#4535)
* fix: Removed protobuf as a required dependency Signed-off-by: Bhargav Dodla <bdodla@expediagroup.com> * fix: Removed install-protoc-dependencies target Signed-off-by: Bhargav Dodla <bdodla@expediagroup.com> --------- Signed-off-by: Bhargav Dodla <bdodla@expediagroup.com> Co-authored-by: Bhargav Dodla <bdodla@expediagroup.com>
1 parent b3c93a0 commit 0fb76e9

8 files changed

Lines changed: 8 additions & 23 deletions

‎pyproject.toml‎

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,7 @@
11
[build-system]
22
requires = [
33
"grpcio-tools>=1.56.2,<2",
4-
"grpcio>=1.56.2,<2",
5-
"mypy-protobuf==3.1",
6-
"protobuf==4.24.0",
4+
"mypy-protobuf>=3.1",
75
"pybindgen==0.22.0",
86
"setuptools>=60",
97
"setuptools_scm>=6.2",

‎sdk/python/requirements/py3.10-ci-requirements.txt‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -572,7 +572,6 @@ proto-plus==1.24.0
572572
# google-cloud-datastore
573573
protobuf==4.25.4
574574
# via
575-
# feast (setup.py)
576575
# google-api-core
577576
# google-cloud-bigquery-storage
578577
# google-cloud-bigtable

‎sdk/python/requirements/py3.10-requirements.txt‎

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -89,9 +89,7 @@ partd==1.4.2
8989
prometheus-client==0.20.0
9090
# via feast (setup.py)
9191
protobuf==4.25.4
92-
# via
93-
# feast (setup.py)
94-
# mypy-protobuf
92+
# via mypy-protobuf
9593
psutil==6.0.0
9694
# via feast (setup.py)
9795
pyarrow==17.0.0

‎sdk/python/requirements/py3.11-ci-requirements.txt‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -563,7 +563,6 @@ proto-plus==1.24.0
563563
# google-cloud-datastore
564564
protobuf==4.25.4
565565
# via
566-
# feast (setup.py)
567566
# google-api-core
568567
# google-cloud-bigquery-storage
569568
# google-cloud-bigtable

‎sdk/python/requirements/py3.11-requirements.txt‎

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -87,9 +87,7 @@ partd==1.4.2
8787
prometheus-client==0.20.0
8888
# via feast (setup.py)
8989
protobuf==4.25.4
90-
# via
91-
# feast (setup.py)
92-
# mypy-protobuf
90+
# via mypy-protobuf
9391
psutil==6.0.0
9492
# via feast (setup.py)
9593
pyarrow==17.0.0

‎sdk/python/requirements/py3.9-ci-requirements.txt‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -583,7 +583,6 @@ proto-plus==1.24.0
583583
# google-cloud-datastore
584584
protobuf==4.25.4
585585
# via
586-
# feast (setup.py)
587586
# google-api-core
588587
# google-cloud-bigquery-storage
589588
# google-cloud-bigtable

‎sdk/python/requirements/py3.9-requirements.txt‎

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -91,9 +91,7 @@ partd==1.4.2
9191
prometheus-client==0.20.0
9292
# via feast (setup.py)
9393
protobuf==4.25.4
94-
# via
95-
# feast (setup.py)
96-
# mypy-protobuf
94+
# via mypy-protobuf
9795
psutil==6.0.0
9896
# via feast (setup.py)
9997
pyarrow==17.0.0

‎setup.py‎

Lines changed: 4 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -18,10 +18,9 @@
1818
import shutil
1919
import subprocess
2020
import sys
21-
2221
from pathlib import Path
2322

24-
from setuptools import find_packages, setup, Command
23+
from setuptools import Command, find_packages, setup
2524
from setuptools.command.build_ext import build_ext as _build_ext
2625
from setuptools.command.build_py import build_py
2726
from setuptools.command.develop import develop
@@ -43,7 +42,6 @@
4342
"mmh3",
4443
"numpy>=1.22,<2",
4544
"pandas>=1.4.3,<3",
46-
"protobuf>=4.24.0,<5.0.0",
4745
"pyarrow>=4",
4846
"pydantic>=2.0.0",
4947
"pygments>=2.12.0,<3",
@@ -102,7 +100,7 @@
102100
"psycopg[binary,pool]>=3.0.0,<4",
103101
]
104102

105-
OPENTELEMETRY = ["prometheus_client","psutil"]
103+
OPENTELEMETRY = ["prometheus_client", "psutil"]
106104

107105
MYSQL_REQUIRED = ["pymysql", "types-PyMySQL"]
108106

@@ -139,7 +137,6 @@
139137

140138
GRPCIO_REQUIRED = [
141139
"grpcio>=1.56.2,<2",
142-
"grpcio-tools>=1.56.2,<2",
143140
"grpcio-reflection>=1.56.2,<2",
144141
"grpcio-health-checking>=1.56.2,<2",
145142
]
@@ -160,6 +157,7 @@
160157
"virtualenv==20.23.0",
161158
"cryptography>=35.0,<43",
162159
"ruff>=0.3.3",
160+
"grpcio-tools>=1.56.2,<2",
163161
"grpcio-testing>=1.56.2,<2",
164162
# FastAPI does not correctly pull starlette dependency on httpx see thread(https://github.com/tiangolo/fastapi/issues/5656).
165163
"httpx>=0.23.3",
@@ -403,9 +401,7 @@ def run(self):
403401
use_scm_version=use_scm_version,
404402
setup_requires=[
405403
"grpcio-tools>=1.56.2,<2",
406-
"grpcio>=1.56.2,<2",
407-
"mypy-protobuf==3.1",
408-
"protobuf==4.24.0",
404+
"mypy-protobuf>=3.1",
409405
"pybindgen==0.22.0",
410406
"setuptools_scm>=6.2",
411407
],

0 commit comments

Comments
 (0)