Skip to content
This repository was archived by the owner on Mar 23, 2026. It is now read-only.

Commit cadffb6

Browse files
Remove dependency of static error message in implementation coverage script (#13116)
1 parent fd33aaf commit cadffb6

1 file changed

Lines changed: 1 addition & 11 deletions

File tree

scripts/capture_notimplemented_responses.py

Lines changed: 1 addition & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -190,7 +190,7 @@ def map_to_notimplemented(row: RowEntry) -> bool:
190190
Some simple heuristics to check the API responses and classify them into implemented/notimplemented
191191
192192
Ideally they all should behave the same way when receiving requests for not yet implemented endpoints
193-
(501 with a "not yet implemented" message)
193+
(501 error code and avoids relying on static "not yet implemented" error message strings)
194194
195195
:param row: the RowEntry
196196
:return: True if we assume it is not implemented, False otherwise
@@ -233,16 +233,6 @@ def map_to_notimplemented(row: RowEntry) -> bool:
233233
and "The requested URL was not found on the server" in row.get("error_message")
234234
):
235235
return True
236-
if (
237-
row["status_code"] == 501
238-
and row.get("error_message") is not None
239-
and "not yet implemented" in row.get("error_message", "")
240-
):
241-
return True
242-
if row.get("error_message") is not None and "not yet implemented" in row.get(
243-
"error_message", ""
244-
):
245-
return True
246236
if row["status_code"] == 501:
247237
return True
248238
if (

0 commit comments

Comments
 (0)