Fix format-modified Makefile target so it fails fast

purcell · purcell · commit 90282073586e · 2025-11-07T17:59:30.000Z
In the existing version, a failure in the first command would not
short-circuit execution of the second, but it should.
diff --git a/Makefile b/Makefile
@@ -135,10 +135,9 @@ check-aws-markers:     		  ## Lightweight check to ensure all AWS tests have pro
 format:            		  ## Run ruff to format the whole codebase
 	($(VENV_RUN); python -m ruff check --output-format=full --fix .; python -m ruff format .)
 
-format-modified:          ## Run ruff to format only modified code
-	($(VENV_RUN); \
-	  python -m ruff check --output-format=full --fix `git diff --diff-filter=d --name-only HEAD | grep '\.py$$' | xargs`; \
-	  python -m ruff format `git diff --diff-filter=d --name-only HEAD | grep '\.py$$' | xargs`)
+format-modified:                  ## Run ruff to format only modified code
+	$(VENV_RUN); python -m ruff check --output-format=full --fix `git diff --diff-filter=d --name-only HEAD | grep '\.py$$' | xargs`
+	$(VENV_RUN); python -m ruff format `git diff --diff-filter=d --name-only HEAD | grep '\.py$$' | xargs`
 
 asf-regenerate:                   ## Regenerate ASF APIs
 	$(VENV_RUN); python -m localstack.aws.scaffold upgrade
