Remove __len__ override for variable store

tiurin · tiurin · commit 82986472b6f0 · 2026-02-23T16:30:39.000+01:00
Overriding __len__ broke many tests, there might be implicit checks like `if variable_store:` that were breaking with the override, outside of test state functionality.

Changing to a more explicit length check
diff --git a/localstack-core/localstack/services/stepfunctions/asl/eval/test_state/environment.py b/localstack-core/localstack/services/stepfunctions/asl/eval/test_state/environment.py
@@ -51,8 +51,9 @@ def __init__(
             variable_store=variable_store,
         )
         self.inspection_data = InspectionData()
-        if variable_store:
-            self.inspection_data["variables"] = to_json_str(variable_store.to_key_value_dict())
+        variables = variable_store.to_dict()
+        if variables:
+            self.inspection_data["variables"] = to_json_str(variables)
         self.mock = mock
 
     def is_test_state_mocked_mode(self) -> bool:
diff --git a/localstack-core/localstack/services/stepfunctions/asl/eval/variable_store.py b/localstack-core/localstack/services/stepfunctions/asl/eval/variable_store.py
@@ -89,7 +89,7 @@ def get_assigned_variables(self) -> dict[str, str]:
             assigned_variables[traced_declaration_identifier] = traced_declaration_value_json_str
         return assigned_variables
 
-    def to_key_value_dict(self) -> dict[str, str]:
+    def to_dict(self) -> dict[str, str]:
         assigned_variables: dict[str, str] = {}
         for traced_declaration_identifier in self._declaration_tracing:
             assigned_variables[traced_declaration_identifier] = self.get(
@@ -131,6 +131,3 @@ def get_variable_declarations(self) -> VariableDeclarations:
             [self._outer_variable_declaration_cache, inner_variable_declarations_cache]
         )
         return self._variable_declarations_cache
-
-    def __len__(self):
-        return len(self._declaration_tracing)
