Add validated test for nested intrinsics

simonrw · simonrw · commit 43c1fe6d972a · 2025-09-16T11:35:18.000+01:00
diff --git a/tests/aws/services/cloudformation/test_change_set_fn_select.py b/tests/aws/services/cloudformation/test_change_set_fn_select.py
@@ -236,3 +236,73 @@ def test_invalid_select_index_type(self, snapshot, aws_client, cleanups, select_
             )
 
         snapshot.match("error", exc_info.value.response)
+
+    @markers.aws.validated
+    def test_nested_select_within_other_intrinsics(self, snapshot, deploy_cfn_template):
+        template = json.dumps(
+            {
+                "Resources": {
+                    "Repo": {
+                        "Type": "AWS::ECR::Repository",
+                    },
+                    "Parameter": {
+                        "Type": "AWS::SSM::Parameter",
+                        "Properties": {
+                            "Type": "String",
+                            "Value": {
+                                "Fn::Join": [
+                                    "",
+                                    [
+                                        {
+                                            "Fn::Select": [
+                                                4,
+                                                {
+                                                    "Fn::Split": [
+                                                        ":",
+                                                        {"Fn::GetAtt": ["Repo", "Arn"]},
+                                                    ]
+                                                },
+                                            ]
+                                        },
+                                        ".dkr.ecr.",
+                                        {
+                                            "Fn::Select": [
+                                                3,
+                                                {
+                                                    "Fn::Split": [
+                                                        ":",
+                                                        {"Fn::GetAtt": ["Repo", "Arn"]},
+                                                    ]
+                                                },
+                                            ]
+                                        },
+                                        ".",
+                                        {"Ref": "AWS::URLSuffix"},
+                                        "/",
+                                        {"Ref": "Repo"},
+                                    ],
+                                ]
+                            },
+                        },
+                    },
+                },
+                "Outputs": {
+                    "RepoName": {"Value": {"Ref": "Repo"}},
+                    "ParameterValue": {
+                        "Value": {
+                            "Fn::GetAtt": ["Parameter", "Value"],
+                        },
+                    },
+                },
+            }
+        )
+        stack = deploy_cfn_template(template=template)
+        snapshot.add_transformer(snapshot.transform.regex(stack.outputs["RepoName"], "<repo-name>"))
+        # the domain name is different between AWS and LocalStack so transform this value out
+        snapshot.add_transformer(
+            snapshot.transform.regex(
+                r"(localhost\.localstack\.cloud(:\d+)?|amazonaws\.com)", "<domain>"
+            )
+        )
+
+        snapshot.match("parameter-value", stack.outputs)
diff --git a/tests/aws/services/cloudformation/test_change_set_fn_select.snapshot.json b/tests/aws/services/cloudformation/test_change_set_fn_select.snapshot.json
@@ -2436,5 +2436,14 @@
         }
       }
     }
+  },
+  "tests/aws/services/cloudformation/test_change_set_fn_select.py::TestChangeSetFnSelect::test_nested_select_within_other_intrinsics": {
+    "recorded-date": "16-09-2025, 10:30:37",
+    "recorded-content": {
+      "parameter-value": {
+        "ParameterValue": "111111111111.dkr.ecr.<region>.<domain>/<repo-name>",
+        "RepoName": "<repo-name>"
+      }
+    }
   }
 }
diff --git a/tests/aws/services/cloudformation/test_change_set_fn_select.validation.json b/tests/aws/services/cloudformation/test_change_set_fn_select.validation.json
@@ -43,5 +43,14 @@
       "teardown": 0.0,
       "total": 0.14
     }
+  },
+  "tests/aws/services/cloudformation/test_change_set_fn_select.py::TestChangeSetFnSelect::test_nested_select_within_other_intrinsics": {
+    "last_validated_date": "2025-09-16T10:30:37+00:00",
+    "durations_in_seconds": {
+      "setup": 0.95,
+      "call": 12.37,
+      "teardown": 6.51,
+      "total": 19.83
+    }
   }
 }

Original file line number	Diff line number	Diff line change
`@@ -2436,5 +2436,14 @@`
`2436`	`2436`	`}`
`2437`	`2437`	`}`
`2438`	`2438`	`}`
	`2439`	`+ },`
	`2440`	`+ "tests/aws/services/cloudformation/test_change_set_fn_select.py::TestChangeSetFnSelect::test_nested_select_within_other_intrinsics": {`
	`2441`	`+ "recorded-date": "16-09-2025, 10:30:37",`
	`2442`	`+ "recorded-content": {`
	`2443`	`+ "parameter-value": {`
	`2444`	`+ "ParameterValue": "111111111111.dkr.ecr.<region>.<domain>/<repo-name>",`
	`2445`	`+ "RepoName": "<repo-name>"`
	`2446`	`+ }`
	`2447`	`+ }`
`2439`	`2448`	`}`
`2440`	`2449`	`}`
Original file line number	Diff line number	Diff line change
`@@ -43,5 +43,14 @@`
`43`	`43`	`"teardown": 0.0,`
`44`	`44`	`"total": 0.14`
`45`	`45`	`}`
	`46`	`+ },`
	`47`	`+ "tests/aws/services/cloudformation/test_change_set_fn_select.py::TestChangeSetFnSelect::test_nested_select_within_other_intrinsics": {`
	`48`	`+ "last_validated_date": "2025-09-16T10:30:37+00:00",`
	`49`	`+ "durations_in_seconds": {`
	`50`	`+ "setup": 0.95,`
	`51`	`+ "call": 12.37,`
	`52`	`+ "teardown": 6.51,`
	`53`	`+ "total": 19.83`
	`54`	`+ }`
`46`	`55`	`}`
`47`	`56`	`}`