harden tests

bentsku · bentsku · commit 3259419f41a7 · 2025-11-04T19:24:22.000+01:00
diff --git a/tests/aws/services/sns/test_sns.py b/tests/aws/services/sns/test_sns.py
@@ -1451,6 +1451,8 @@ def test_creating_subscription(self, sns_create_topic, aws_client, snapshot):
         resp = aws_client.sns.subscribe(
             TopicArn=topic_arn, Protocol="http", Endpoint="http://example.com/"
         )
+        # TODO: investigate why it leaves the subscription in `SNS.ListSubscriptions`, we maybe need to clean up
+        #  after deleting topics, not fully in parity as AWS cleans up instantly
         snapshot.match("create-subscription", resp)
 
     # TODO: parametrize for email protocol
@@ -4017,6 +4019,7 @@ def test_delete_platform_endpoint_with_subscription(
 
         app_name = f"platform-application-{short_uid()}"
         snapshot.add_transformer(RegexTransformer(app_name, "<platform_application>"))
+        snapshot.add_transformer(snapshot.transform.key_value("NextToken"))
         # if tested against AWS, the fixture needs to contain real credentials
         principal, credential = platform_credentials
         attributes = {"PlatformPrincipal": principal, "PlatformCredential": credential}
@@ -4033,7 +4036,8 @@ def test_delete_platform_endpoint_with_subscription(
         if is_aws_cloud():
             time.sleep(20)
 
-        response = aws_client.sns.list_subscriptions()
+        # we list subscriptions by topic, as some tests are not cleaning up properly
+        response = aws_client.sns.list_subscriptions_by_topic(TopicArn=topic_arn)
         snapshot.match("list-subscriptions-pre-delete", response)
 
         response = aws_client.sns.delete_endpoint(EndpointArn=endpoint_arn)
@@ -4043,7 +4047,7 @@ def test_delete_platform_endpoint_with_subscription(
         if is_aws_cloud():
             time.sleep(20)
 
-        response = aws_client.sns.list_subscriptions()
+        response = aws_client.sns.list_subscriptions_by_topic(TopicArn=topic_arn)
         snapshot.match("list-subscriptions-post-delete", response)
 
     @markers.aws.manual_setup_required
diff --git a/tests/aws/services/sns/test_sns.snapshot.json b/tests/aws/services/sns/test_sns.snapshot.json
@@ -6460,10 +6460,10 @@
     }
   },
   "tests/aws/services/sns/test_sns.py::TestSNSPlatformEndpointCrud::test_delete_platform_endpoint_with_subscription": {
-    "recorded-date": "31-10-2025, 21:27:49",
+    "recorded-date": "04-11-2025, 19:18:31",
     "recorded-content": {
       "list-subscriptions-pre-delete": {
-        "NextToken": "AAHhOl6T07LJ89hFxXiaWC4QlQUd8UbuziOx37A3XgerhQ==",
+        "NextToken": "<next-token:1>",
         "Subscriptions": [
           {
             "Endpoint": "arn:<partition>:sns:<region>:111111111111:endpoint/ADM/<platform_application>/<resource:1>",
@@ -6485,7 +6485,7 @@
         }
       },
       "list-subscriptions-post-delete": {
-        "NextToken": "AAHxwWMatFh66c2j/bctn8NEhVsRAwebBzaS6enPfvneEA==",
+        "NextToken": "<next-token:2>",
         "Subscriptions": [
           {
             "Endpoint": "arn:<partition>:sns:<region>:111111111111:endpoint/ADM/<platform_application>/<resource:1>",
diff --git a/tests/aws/services/sns/test_sns.validation.json b/tests/aws/services/sns/test_sns.validation.json
@@ -312,12 +312,12 @@
     }
   },
   "tests/aws/services/sns/test_sns.py::TestSNSPlatformEndpointCrud::test_delete_platform_endpoint_with_subscription": {
-    "last_validated_date": "2025-10-31T21:27:49+00:00",
+    "last_validated_date": "2025-11-04T19:18:31+00:00",
     "durations_in_seconds": {
       "setup": 0.01,
-      "call": 43.6,
-      "teardown": 1.23,
-      "total": 44.84
+      "call": 44.2,
+      "teardown": 1.07,
+      "total": 45.28
     }
   },
   "tests/aws/services/sns/test_sns.py::TestSNSPlatformEndpointCrud::test_get_platform_endpoint_attributes": {

Original file line number	Diff line number	Diff line change
`@@ -6460,10 +6460,10 @@`
`6460`	`6460`	`}`
`6461`	`6461`	`},`
`6462`	`6462`	`"tests/aws/services/sns/test_sns.py::TestSNSPlatformEndpointCrud::test_delete_platform_endpoint_with_subscription": {`
`6463`		`- "recorded-date": "31-10-2025, 21:27:49",`
	`6463`	`+ "recorded-date": "04-11-2025, 19:18:31",`
`6464`	`6464`	`"recorded-content": {`
`6465`	`6465`	`"list-subscriptions-pre-delete": {`
`6466`		`- "NextToken": "AAHhOl6T07LJ89hFxXiaWC4QlQUd8UbuziOx37A3XgerhQ==",`
	`6466`	`+ "NextToken": "<next-token:1>",`
`6467`	`6467`	`"Subscriptions": [`
`6468`	`6468`	`{`
`6469`	`6469`	`"Endpoint": "arn:<partition>:sns:<region>:111111111111:endpoint/ADM/<platform_application>/<resource:1>",`
`@@ -6485,7 +6485,7 @@`
`6485`	`6485`	`}`
`6486`	`6486`	`},`
`6487`	`6487`	`"list-subscriptions-post-delete": {`
`6488`		`- "NextToken": "AAHxwWMatFh66c2j/bctn8NEhVsRAwebBzaS6enPfvneEA==",`
	`6488`	`+ "NextToken": "<next-token:2>",`
`6489`	`6489`	`"Subscriptions": [`
`6490`	`6490`	`{`
`6491`	`6491`	`"Endpoint": "arn:<partition>:sns:<region>:111111111111:endpoint/ADM/<platform_application>/<resource:1>",`