Re-enable C416 ruff rule (#13025)

giograno · web-flow · commit 1d2682572f46 · 2025-08-19T15:01:37.000+02:00
diff --git a/localstack-core/localstack/services/lambda_/api_utils.py b/localstack-core/localstack/services/lambda_/api_utils.py
@@ -715,12 +715,12 @@ def validate_layer_runtimes_and_architectures(
 
     if compatible_runtimes and set(compatible_runtimes).difference(ALL_RUNTIMES):
         constraint = f"Member must satisfy enum value set: {VALID_RUNTIMES}"
-        validation_msg = f"Value '[{', '.join([s for s in compatible_runtimes])}]' at 'compatibleRuntimes' failed to satisfy constraint: {constraint}"
+        validation_msg = f"Value '[{', '.join(list(compatible_runtimes))}]' at 'compatibleRuntimes' failed to satisfy constraint: {constraint}"
         validations.append(validation_msg)
 
     if compatible_architectures and set(compatible_architectures).difference(ARCHITECTURES):
         constraint = "[Member must satisfy enum value set: [x86_64, arm64]]"
-        validation_msg = f"Value '[{', '.join([s for s in compatible_architectures])}]' at 'compatibleArchitectures' failed to satisfy constraint: Member must satisfy constraint: {constraint}"
+        validation_msg = f"Value '[{', '.join(list(compatible_architectures))}]' at 'compatibleArchitectures' failed to satisfy constraint: Member must satisfy constraint: {constraint}"
         validations.append(validation_msg)
 
     return validations
diff --git a/localstack-core/localstack/services/s3/models.py b/localstack-core/localstack/services/s3/models.py
@@ -638,7 +638,7 @@ def pop(self, object_key: ObjectKey, default=None) -> S3Object | None:
 
     def values(self, *_, **__) -> list[S3Object | S3DeleteMarker]:
         # we create a shallow copy with dict to avoid size changed during iteration
-        return [value for value in dict(self._store).values()]
+        return list(dict(self._store).values())
 
     def is_empty(self) -> bool:
         return not self._store
diff --git a/localstack-core/localstack/utils/analytics/metrics/counter.py b/localstack-core/localstack/utils/analytics/metrics/counter.py
@@ -200,10 +200,7 @@ def collect(self) -> list[LabeledCounterPayload]:
                 )
 
             # Create labels dictionary
-            labels_dict = {
-                label_name: label_value
-                for label_name, label_value in zip(self._labels, label_values)
-            }
+            labels_dict = dict(zip(self._labels, label_values))
 
             payload.append(
                 LabeledCounterPayload(
diff --git a/pyproject.toml b/pyproject.toml
@@ -213,7 +213,6 @@ ignore = [
     "B024", # TODO x is an abstract base class, but it has no abstract methods
     "B027", # TODO `Server.do_shutdown` is an empty method in an abstract base class, but has no abstract decorator
     "B904", # TODO Within an `except` clause, raise exceptions with `raise ... from err` or `raise ... from None` to distinguish them from errors in exception handling
-    "C416", # TODO Unnecessary `set` comprehension
     "C901", # TODO function is too complex
     "E402", # TODO Module level import not at top of file
     "E501", # E501 Line too long - handled by black, see https://docs.astral.sh/ruff/faq/#is-ruff-compatible-with-black
diff --git a/scripts/capture_notimplemented_responses.py b/scripts/capture_notimplemented_responses.py
@@ -37,7 +37,7 @@
 
 # will only include available services
 response = requests.get("http://localhost:4566/_localstack/health").content.decode("utf-8")
-latest_services_pro = [k for k in json.loads(response).get("services").keys()]
+latest_services_pro = list(json.loads(response).get("services").keys())
 
 exclude_services = {"azure"}
 latest_services_pro = [s for s in latest_services_pro if s not in exclude_services]
diff --git a/tests/aws/services/cloudformation/test_template_engine.py b/tests/aws/services/cloudformation/test_template_engine.py
@@ -1210,7 +1210,7 @@ def test_pyplate_param_type_list(self, deploy_cfn_template, aws_client, snapshot
         assert bucket_name_output
 
         tagging = aws_client.s3.get_bucket_tagging(Bucket=bucket_name_output)
-        tags_s3 = [tag for tag in tagging["TagSet"]]
+        tags_s3 = list(tagging["TagSet"])
 
         resp = []
         for tag in tags_s3:
diff --git a/tests/unit/utils/test_collections.py b/tests/unit/utils/test_collections.py
@@ -43,7 +43,7 @@ def test_immutable_dict():
     d1 = ImmutableDict({"a": ["b"], "c": 1})
 
     assert dict(d1) == {"a": ["b"], "c": 1}
-    assert {k for k in d1} == {"a", "c"}
+    assert set(d1) == {"a", "c"}
     assert d1["a"] == ["b"]
     assert d1["c"] == 1
     assert len(d1) == 2
